Skip to content

Commit b7b241f

Browse files
authored
Merge pull request abuzuhri#910 from TManITtech/main
Fix potential race condition in RequestService.ExecuteRequestTry method by capturing Request reference
2 parents 51bd842 + d8d032e commit b7b241f

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Source/FikaAmazonAPI/Services/RequestService.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,9 @@ protected async Task<T> ExecuteRequestTry<T>(RateLimitType rateLimitType = RateL
128128

129129
//Remove AWS authorization
130130
//Request = await TokenGeneration.SignWithSTSKeysAndSecurityTokenAsync(Request, RequestClient.Options.BaseUrl.Host, AmazonCredential, cancellationToken);
131-
var response = await RequestClient.ExecuteAsync<T>(Request, cancellationToken);
132-
LogRequest(Request, response);
131+
var currentRequest = Request;
132+
var response = await RequestClient.ExecuteAsync<T>(currentRequest, cancellationToken);
133+
LogRequest(currentRequest, response);
133134
SaveLastRequestHeader(response.Headers);
134135
await SleepForRateLimit(response.Headers, rateLimitType, cancellationToken);
135136
ParseResponse(response);

0 commit comments

Comments
 (0)