Skip to content

Implement Vulkan renderer#1330

Open
JKSunny wants to merge 48 commits into
JACoders:masterfrom
JKSunny:openjk-dev
Open

Implement Vulkan renderer#1330
JKSunny wants to merge 48 commits into
JACoders:masterfrom
JKSunny:openjk-dev

Conversation

@JKSunny
Copy link
Copy Markdown

@JKSunny JKSunny commented May 9, 2026

Vulkans landing page with info: https://jksunny.github.io/

JKSunny and others added 30 commits June 22, 2022 14:48
draw the fog color.

Keeps visuals similar to vanilla in edge cases where fog would be shown instead of the void.

Co-Authored-By: Spaghetti <15520009+Spaghetti657@users.noreply.github.com>
…hader

Co-Authored-By: Spaghetti <15520009+Spaghetti657@users.noreply.github.com>
- Flares (ex map. t2_dpred) are clipping through walls at greater distances.

Also flare fade out is clipping and looks wrong, merge with rend2 disabled method.
https://github.com/SomaZ/OpenJK/blob/323f230523b9bf14b41fff14f6018299cb3898c5/codemp/rd-rend2/tr_flares.cpp#L294
Vulkan: fix screenmap image layout transitions (9f28557)
Vulkan: do not set transient flag for depth/stencil attachment when bloom (and thus - post-bloom pass) is enabled (bda5b5a)
Vulkan: Add debug utills with define guards (82ffb3c)
Vulkan: added descriptor index definitions (fdf7bfb)
@JKSunny JKSunny requested a review from a team as a code owner May 9, 2026 09:19
Comment thread shared/sdl/sdl_window.cpp
@@ -327,9 +330,17 @@ static rserr_t GLimp_SetMode(glconfig_t *glConfig, const windowDesc_t *windowDes
int display = 0;
int x = SDL_WINDOWPOS_UNDEFINED, y = SDL_WINDOWPOS_UNDEFINED;

if ( windowDesc->api == GRAPHICS_API_OPENGL )
Com_Printf("grahpis mode: %d", (int)windowDesc->api);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Com_Printf("grahpis mode: %d", (int)windowDesc->api);
Com_Printf("graphics mode: %d", (int)windowDesc->api);

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch

Comment thread .gitignore
#############
[Bb]uild*/
cmake-build-*
codemp/rd-vulkan/shaders/tools/compile_threaded.exe
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, where does this come from?
Should this be in the project gitignore, or your local?
Compiled versions of bin2hex and bindshader have been committed. All or nothing?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing,

When developers want to compile GLSL->SPIR-V, compile_threaded.bat uses cl.exe to compile it.
Same for the other two.

I added it to .gitignore cus Windows Firewall/Github Desktop was whining about something.
The other compiled executables are tiny, thats why I left them.

I can add a .gitignore to the tools folder and remove it from the root one.
or a global *.exe, w/e you prefer, let me know :)

@JKSunny
Copy link
Copy Markdown
Author

JKSunny commented May 12, 2026

Been brought to my attention that

ri.VK_destroyWindow = WIN_VK_destroyWindow;

Is dead code, which I will add to my todo to remove as well for this PR.

Which leaves just 3 refapi changes

@SomaZ SomaZ linked an issue May 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Will there be official support for Vulkan based on this fork?

3 participants