Skip to content

Commit acf195c

Browse files
committed
test: improves navigation selectors and test formatting
1 parent 45ca47b commit acf195c

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

e2e/homepage.spec.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ test.describe('Homepage', () => {
99
await expect(
1010
page.getByRole('heading', { name: /ship your saas/i }),
1111
).toBeVisible();
12-
await expect(main.getByRole('link', { name: /get started/i })).toBeVisible();
12+
await expect(
13+
main.getByRole('link', { name: /get started/i }),
14+
).toBeVisible();
1315
await expect(
1416
main.getByRole('link', { name: /documentation/i }),
1517
).toBeVisible();
@@ -32,18 +34,20 @@ test.describe('Homepage', () => {
3234
main.getByRole('heading', { name: 'Authentication' }),
3335
).toBeVisible();
3436
await expect(main.getByRole('heading', { name: 'Payments' })).toBeVisible();
35-
await expect(main.getByRole('heading', { name: 'Turbopack' })).toBeVisible();
37+
await expect(
38+
main.getByRole('heading', { name: 'Turbopack' }),
39+
).toBeVisible();
3640
});
3741

3842
test('navbar links navigate correctly', async ({ page }) => {
3943
await page.goto('/');
40-
const nav = page.getByRole('navigation');
44+
const nav = page.getByLabel('Main navigation');
4145

4246
await nav.getByRole('link', { name: 'Pricing' }).click();
4347
await expect(page).toHaveURL('/pricing');
4448

4549
await page
46-
.getByRole('navigation')
50+
.getByLabel('Main navigation')
4751
.getByRole('link', { name: 'AinzStack' })
4852
.click();
4953
await expect(page).toHaveURL('/');

e2e/smoke.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ test.describe('Marketing Pages', () => {
77

88
await expect(page).toHaveTitle(/AinzStack/i);
99
await expect(page.locator('h1')).toBeVisible();
10-
await expect(main.getByRole('link', { name: /get started/i })).toBeVisible();
10+
await expect(
11+
main.getByRole('link', { name: /get started/i }),
12+
).toBeVisible();
1113
});
1214

1315
test('pricing page renders three plans', async ({ page }) => {
@@ -20,7 +22,7 @@ test.describe('Marketing Pages', () => {
2022

2123
test('navbar links are visible on desktop', async ({ page }) => {
2224
await page.goto('/');
23-
const nav = page.getByRole('navigation');
25+
const nav = page.getByLabel('Main navigation');
2426

2527
await expect(nav.getByRole('link', { name: 'Pricing' })).toBeVisible();
2628
await expect(nav.getByRole('link', { name: 'Docs' })).toBeVisible();

0 commit comments

Comments
 (0)