Skip to content

Commit 3bfa595

Browse files
committed
Fix rebase conflicts
1 parent df28900 commit 3bfa595

2 files changed

Lines changed: 6 additions & 26 deletions

File tree

kartothek/io_components/merge.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import logging
22
from functools import partial, reduce
3-
from typing import Dict, List, Optional
3+
from typing import TYPE_CHECKING, Callable, Dict, List, Optional, cast
44

55
import pandas as pd
66

@@ -10,6 +10,10 @@
1010
from kartothek.io_components.read import dispatch_metapartitions_from_factory
1111
from kartothek.io_components.utils import _instantiate_store, _make_callable
1212

13+
if TYPE_CHECKING:
14+
from simplekv import KeyValueStore
15+
16+
1317
LOGGER = logging.getLogger(__name__)
1418

1519

@@ -138,7 +142,7 @@ def align_datasets_many(
138142
dataset_factories = [
139143
DatasetFactory(
140144
dataset_uuid=dataset_uuid,
141-
store_factory=_make_callable(store),
145+
store_factory=cast(Callable[[], "KeyValueStore"], _make_callable(store)),
142146
load_schema=True,
143147
load_all_indices=False,
144148
load_dataset_metadata=True,

kartothek/io_components/read.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -39,30 +39,6 @@ def dispatch_metapartitions_from_factory(
3939
...
4040

4141

42-
@overload
43-
def dispatch_metapartitions_from_factory(
44-
dataset_factory: Union[DatasetFactory, Callable],
45-
label_filter: Optional[Callable] = None,
46-
concat_partitions_on_primary_index: bool = False,
47-
predicates: Optional[Any] = None,
48-
store: Optional[Callable] = None,
49-
dispatch_by: None = None,
50-
) -> Iterator[MetaPartition]:
51-
...
52-
53-
54-
@overload
55-
def dispatch_metapartitions_from_factory(
56-
dataset_factory: Union[DatasetFactory, Callable],
57-
label_filter: Optional[Callable],
58-
concat_partitions_on_primary_index,
59-
predicates: Optional[Any],
60-
store: Optional[Callable],
61-
dispatch_by: List[str],
62-
) -> Iterator[List[MetaPartition]]:
63-
...
64-
65-
6642
@normalize_args
6743
def dispatch_metapartitions_from_factory(
6844
dataset_factory: DatasetFactory,

0 commit comments

Comments
 (0)