Skip to content

Type dispatch_metapartitions#246

Merged
fjetter merged 2 commits into
JDASoftwareGroup:masterfrom
xhochy:type-dispatch_metapartitions
Mar 12, 2020
Merged

Type dispatch_metapartitions#246
fjetter merged 2 commits into
JDASoftwareGroup:masterfrom
xhochy:type-dispatch_metapartitions

Conversation

@xhochy

@xhochy xhochy commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

Extracts more typings from #243

@fjetter

fjetter commented Mar 12, 2020

Copy link
Copy Markdown
Collaborator

build failure due to flake8 error

kartothek/io_components/read.py:2:1: F401 'typing.Any' imported but unused
3179kartothek/serialization/_generic.py:15:1: F401 'typing.Any' imported but unused

Comment thread kartothek/serialization/_generic.py Outdated
Comment thread kartothek/io_components/read.py Outdated
@codecov

codecov Bot commented Mar 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #246 into master will increase coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   89.66%   89.73%   +0.06%     
==========================================
  Files          39       39              
  Lines        3715     3720       +5     
  Branches      902      901       -1     
==========================================
+ Hits         3331     3338       +7     
  Misses        224      224              
+ Partials      160      158       -2     
Impacted Files Coverage Δ
kartothek/io_components/read.py 92.72% <75.00%> (+0.57%) ⬆️
kartothek/serialization/_generic.py 93.24% <100.00%> (ø)
kartothek/io/eager.py 77.09% <0.00%> (+0.12%) ⬆️
kartothek/core/common_metadata.py 95.39% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab8b2a...0124a94. Read the comment docs.

@fjetter fjetter merged commit de6bef0 into JDASoftwareGroup:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants