Feature/kartothek table name tests#465
Open
MartinHaffner wants to merge 82 commits into
Open
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.3.1 to v1.4.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.3.1...0e28ff8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iling at the moment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some tests to check the behaviour:
In some cases the interface to specify an alternative table name does not yet or does no more exist; these tests were added for the sake of completeness, but will be skipped.
In some other cases, KTK failed with an unspecific error where a graceful failure with a meaningful Error was expected; these are marked as xfails.
This PR depends on
which again depends on:
BY internal: Refers to JIRA Task LDE-1084.
Doc build fails in the forked repo at the moment; but I was told that in some cases it would work in the upstream repo anyway, so I'm just giving it a try...