refactor: JDS Tooltip 컴포넌트 vanilla-extract 마이그레이션#442
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ccconac
left a comment
There was a problem hiding this comment.
간단하게 코멘트 남겨 두었으니 시간 괜찮으실 때 확인 부탁드려요.
작업하시느라 수고 많으셨습니다~! 👏
|
Warning Review limit reached
More reviews will be available in 5 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTooltip 스타일을 Vanilla Extract로 옮기고 컴포넌트를 forwardRef로 리팩터링했습니다. Trigger/Content 동작과 Storybook 예제가 asChild 패턴과 접근성 라벨로 업데이트되었으며 앱의 툴팁 트리거 마크업도 정리되었습니다. 변경 사항Tooltip 컴포넌트 Vanilla Extract 마이그레이션
Sequence DiagramsequenceDiagram
participant Consumer
participant TooltipRoot
participant TooltipTrigger
participant TooltipContent
participant TooltipPrimitive
Consumer->>TooltipRoot: children, ...radixProps (no delayDuration default)
TooltipRoot->>TooltipPrimitive.Root: spread props directly
Consumer->>TooltipTrigger: ref, asChild=false (default changed)
TooltipTrigger->>TooltipPrimitive.Trigger: forwardRef and props
Consumer->>TooltipContent: ref, forceMount, side, sideOffset
TooltipContent->>TooltipPrimitive.Portal: render with forceMount
TooltipContent->>TooltipPrimitive.Content: apply vanilla-extract className via clsx
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 작업 내용
💡 자세한 설명
스타일 변경사항
semantic-textStyle-body-sm-normal에서semantic-textStyle-label-sm-normal로 변경되었습니다.📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
✅ 셀프 체크리스트
closes #440
Summary by CodeRabbit