refactor: 지원 상태 확인 API 파라미터 변경 (#377)

* refactor: 이메일 대신 memberId를 사용하도록 checkApplyStatus를 수

* refactor: checkApplyStatus 메서드 파라미터를 email에서 memberId로 수정

* test: checkApplyStatus 테스트 메서드 파라미터를 email에서 memberId로 수정

Author: 023-dev

src/main/java/org/ject/support/domain/apply/controller/ApplyApiSpec.java

@@ -3,7 +3,6 @@
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.tags.Tag;
 import jakarta.validation.Valid;
-import jakarta.validation.constraints.Email;
 import org.ject.support.common.security.AuthPrincipal;
 import org.ject.support.domain.apply.dto.ApplyProfileRequest;
 import org.ject.support.domain.apply.dto.ApplyStatusResponse;
@@ -48,7 +47,7 @@ void submitApplication(@AuthPrincipal Long memberId,
                     - TEMP_SAVED: 작성 중인 지원서가 있는 경우
                     - SUBMITTED: 이미 지원서를 제출한 경우
                     """)
-    ApplyStatusResponse checkApplyStatus(@RequestParam @Email String email);
+    ApplyStatusResponse checkApplyStatus(@AuthPrincipal Long memberId);
 
     @Operation(
             summary = "프로필 작성(저장)",

src/main/java/org/ject/support/domain/apply/controller/ApplyController.java

@@ -1,7 +1,6 @@
 package org.ject.support.domain.apply.controller;
 
 import jakarta.validation.Valid;
-import jakarta.validation.constraints.Email;
 import lombok.RequiredArgsConstructor;
 import org.ject.support.common.security.AuthPrincipal;
 import org.ject.support.domain.apply.dto.ApplyProfileRequest;
@@ -59,9 +58,9 @@ public void submitApplication(@AuthPrincipal Long memberId,
 
     @Override
     @GetMapping("/status")
-    @PreAuthorize("permitAll()")
-    public ApplyStatusResponse checkApplyStatus(@RequestParam @Email String email) {
-        return applyUsecase.checkApplyStatus(email);
+    @PreAuthorize("hasRole('ROLE_APPLY')")
+    public ApplyStatusResponse checkApplyStatus(@AuthPrincipal Long memberId) {
+        return applyUsecase.checkApplyStatus(memberId);
     }
 
     @Override

src/main/java/org/ject/support/domain/apply/service/ApplyService.java

@@ -170,11 +170,11 @@ public void submitApplication(Long memberId,
 
     @Override
     @PeriodAccessible(permitAllJob = true)
-    public ApplyStatusResponse checkApplyStatus(String email) {
-        Member member = memberRepository.findByEmail(email)
+    public ApplyStatusResponse checkApplyStatus(Long memberId) {
+        memberRepository.findById(memberId)
                 .orElseThrow(() -> new MemberException(MemberErrorCode.NOT_FOUND_MEMBER));
 
-        return applyRepository.findByMemberIdInActiveRecruit(member.getId(), LocalDateTime.now())
+        return applyRepository.findByMemberIdInActiveRecruit(memberId, LocalDateTime.now())
                 .map(ApplyStatusResponse::of)
                 .orElseThrow(() -> new ApplyException(NOT_FOUND_APPLY));
     }

src/main/java/org/ject/support/domain/apply/service/ApplyUsecase.java

@@ -24,7 +24,7 @@ void submitApplication(Long memberId,
                            Map<String, String> answers,
                            List<ApplyPortfolioDto> portfolios);
 
-    ApplyStatusResponse checkApplyStatus(String email);
+    ApplyStatusResponse checkApplyStatus(Long memberId);
 
     void saveProfile(Long memberId, ApplyProfileRequest request);
 }

src/test/java/org/ject/support/domain/apply/service/ApplyServiceTest.java

@@ -193,16 +193,18 @@ class ApplyServiceTest extends UnitTestSupport {
     @Test
     void 지원상태_조회_시_프로필작성을_하지_않았을_경우_예외발생() {
         // given
-        String email = "test@example.com";
         Member member = Member.builder()
+                .id(1L)
+                .name("지원자명")
+                .phoneNumber("01012345678")
                 .build();
-        given(memberRepository.findByEmail(email))
+        given(memberRepository.findById(member.getId()))
                 .willReturn(Optional.of(member));
         given(applyRepository.findByMemberIdInActiveRecruit(eq(member.getId()), any()))
                 .willReturn(Optional.empty());
 
         // expected
-        assertThatThrownBy(() -> applyService.checkApplyStatus(email))
+        assertThatThrownBy(() -> applyService.checkApplyStatus(member.getId()))
                 .isInstanceOf(ApplyException.class)
                 .extracting("errorCode")
                 .isEqualTo(ApplyErrorCode.NOT_FOUND_APPLY);
@@ -211,13 +213,12 @@ class ApplyServiceTest extends UnitTestSupport {
     @Test
     void 작성_중인_지원서가_있는_경우_TEMP_SAVED_반환() {
         // given
-        String email = "test@example.com";
         Member member = Member.builder()
                 .id(1L)
                 .name("지원자명")
                 .phoneNumber("01012345678")
                 .build();
-        given(memberRepository.findByEmail(email))
+        given(memberRepository.findById(member.getId()))
                 .willReturn(Optional.of(member));
         given(applyRepository.findByMemberIdInActiveRecruit(eq(member.getId()), any()))
                 .willReturn(Optional.of(
@@ -228,7 +229,7 @@ class ApplyServiceTest extends UnitTestSupport {
                 ));
 
         // when
-        ApplyStatusResponse result = applyService.checkApplyStatus(email);
+        ApplyStatusResponse result = applyService.checkApplyStatus(member.getId());
 
         // then
         assertThat(result.status()).isEqualTo(TEMP_SAVED);
@@ -237,13 +238,12 @@ class ApplyServiceTest extends UnitTestSupport {
     @Test
     void 지원서를_제출한_지원자에_대한_제출_상태_확인_시_SUBMITTED_반환() {
         // given
-        String email = "test@example.com";
         Member member = Member.builder()
-                        .id(1L)
-                        .name("지원자명")
-                        .phoneNumber("01012345678")
-                        .build();
-        given(memberRepository.findByEmail(email))
+                .id(1L)
+                .name("지원자명")
+                .phoneNumber("01012345678")
+                .build();
+        given(memberRepository.findById(member.getId()))
                 .willReturn(Optional.of(member));
         given(applyRepository.findByMemberIdInActiveRecruit(eq(member.getId()), any()))
                 .willReturn(Optional.of(
@@ -254,7 +254,7 @@ class ApplyServiceTest extends UnitTestSupport {
                 ));
 
         // when
-        ApplyStatusResponse result = applyService.checkApplyStatus(email);
+        ApplyStatusResponse result = applyService.checkApplyStatus(member.getId());
 
         // then
         assertThat(result.status()).isEqualTo(SUBMITTED);