feat: 몰입형 투표 랜덤 다음 조회 API 추가#218
Merged
Merged
Conversation
- findRandomExcluding: excludeIds 제외하고 랜덤 조회 - findRandom: 첫 조회용 랜덤 쿼리 - countOngoing: 진행 중 투표 개수 조회
- getNextRandom 메서드 시그니처 정의 - ImmersiveNextResult record 추가
- excludeIds 제외하고 랜덤 투표 조회 - 기존 toFeedItem 메서드 재사용 - imageUrl null 시 thumbnailUrl로 폴백 처리
- ImmersiveNextRequest: excludeIds, size 파라미터 - ImmersiveNextResponse: 기존 피드 응답 구조와 동일 - 무한 순환: 모든 투표 소진 시 빈 배열 반환
- imageUrl 있으면 그대로 반환 - imageUrl null이면 thumbnailUrl로 폴백
|
Caution Review failedPull request was closed or merged during review 개요사용자가 이전 투표를 제외하고 진행 중인 투표를 랜덤하게 조회하는 무한 순환 기능을 추가했습니다. 요청 DTO, 저장소 쿼리, 서비스 구현, REST 엔드포인트를 완성하고, 이미지 URL 폴백 로직을 개선했습니다. 변경사항Immersive 랜덤 투표 조회
예상 코드 리뷰 노력🎯 3 (Moderate) | ⏱️ ~20 분 추천 레이블
추천 리뷰어
시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
빌드 성공 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🔍 작업 내용
위로 스와이프 시 랜덤 다음 투표, 아래로 스와이프 시 이전 투표 탐색을 위한 API 추가
📝 변경 사항
POST /api/immersive-votes/next엔드포인트 추가💬 리뷰어에게
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선사항