Skip to content

fix: 투표 취소 후 채팅 메시지 senderVoteOption null 반환#222

Merged
tlarbals824 merged 1 commit into
developfrom
fix/chat-null-sender-vote-option-after-cancel
Jun 3, 2026
Merged

fix: 투표 취소 후 채팅 메시지 senderVoteOption null 반환#222
tlarbals824 merged 1 commit into
developfrom
fix/chat-null-sender-vote-option-after-cancel

Conversation

@tlarbals824

Copy link
Copy Markdown
Collaborator

Summary

투표 참여를 취소한 사용자의 기존 채팅 메시지에서 senderVoteOption이 더 이상 A/B로 내려가지 않고 null로 반환됩니다.

Changes

  • VoteQueryUseCase.findSelectedOptionCode() 추가 — 현재 참여 상태가 없으면 empty
  • ChatService 메시지 조회/전송, ChatMessageEventListener WebSocket 브로드캐스트에서 위 API 사용

Test plan

  • ChatServiceTest, ChatMessageEventListenerTest 통과
  • 투표 → 채팅 전송 → 동일 옵션 재클릭(취소) → 메시지 목록 재조회 시 본인 메시지 senderVoteOption: null 확인

Resolve chat message senderVoteOption from current participation only.
Users who canceled their vote no longer expose A/B on past messages.
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tlarbals824, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0e84d5f-9dc2-41b6-a8d6-107033036906

📥 Commits

Reviewing files that changed from the base of the PR and between e8abdcf and 4869fc0.

📒 Files selected for processing (6)
  • src/main/java/com/ject/vs/chat/adapter/event/ChatMessageEventListener.java
  • src/main/java/com/ject/vs/chat/port/ChatService.java
  • src/main/java/com/ject/vs/vote/port/VoteQueryService.java
  • src/main/java/com/ject/vs/vote/port/in/VoteQueryUseCase.java
  • src/unitTest/java/com/ject/vs/chat/adapter/event/ChatMessageEventListenerTest.java
  • src/unitTest/java/com/ject/vs/chat/port/ChatServiceTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/chat-null-sender-vote-option-after-cancel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug label Jun 3, 2026
@tlarbals824 tlarbals824 merged commit dba8b7b into develop Jun 3, 2026
3 checks passed
@github-actions github-actions Bot deleted the fix/chat-null-sender-vote-option-after-cancel branch June 3, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant