fix: 투표 종료 알림 body 정리 및 투표 기간 분 단위 옵션 추가#234
Merged
Merged
Conversation
프론트 UI 시안에 맞춰 알림 body를 순수 투표 제목만 내려주도록 변경
|
Caution Review failedPull request was closed or merged during review WalkthroughPR는 투표 지속 시간 옵션을 확장하고 투표 종료 알림 메시지 형식을 단순화합니다. 분 단위 투표 기간이 추가되며, 알림 본문이 제목만 직접 사용하도록 변경되고 관련 테스트가 이를 반영합니다. Changes투표 기간 및 알림 업데이트
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
빌드 성공 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🔍 작업 내용
body값을 순수 투표 제목만 내려주도록 수정했습니다.📝 변경 사항
body형식 변경"[투표 제목] 결과 보러가기""투표 제목"(대괄호 및 ' 결과 보러가기' 문구 제거)VoteDuration에 분 단위 옵션 추가 (MINUTES_7,MINUTES_10,MINUTES_15)💬 리뷰어에게
title("투표 결과가 공개됐어요")은 별개 필드라 변경 범위에서 제외했습니다. 함께 조정이 필요한지 확인 부탁드립니다.Summary by CodeRabbit
릴리스 노트