test: 컨트롤러 테스트와 불필요한 테스트 더블 정리

Author: mike7643

docs/solutions/test-failures/prefer-manual-sut-construction-when-only-real-collaborators-are-needed.md

@@ -0,0 +1,27 @@
+---
+module: test
+problem_type: test-failures
+tags:
+  - mockito
+  - injectmocks
+  - unit-test
+---
+
+# Prefer manual SUT construction when only real collaborators are needed
+
+## Context
+
+Some unit tests used `@InjectMocks` with extra `@Mock` or `@Spy` fields only to satisfy constructor injection. That left unused test doubles in the file and made the test setup noisier than the assertions.
+
+## Decision
+
+When a collaborator does not need stubbing or verification, prefer constructing the SUT manually with a real instance or a no-op implementation.
+
+## Applied here
+
+- `LockerSearchResultQueryServiceTest` now constructs the service manually and uses only the doubles it actually asserts against.
+- `LockerSearchQueryServiceTest` now constructs the service manually and uses a real `LockerSearchAssembler` instead of an unused spy.
+
+## Guardrail
+
+If a mock or spy is never stubbed or verified, remove it first and consider replacing `@InjectMocks` with explicit SUT construction.

docs/solutions/test-failures/remove-controller-tests-only-after-targeted-pass.md

@@ -0,0 +1,25 @@
+---
+module: test
+problem_type: test-failures
+tags:
+  - controller-test
+  - cleanup
+  - verification
+---
+
+# Remove controller tests only after targeted pass
+
+## Context
+
+When deleting a broad class of tests, first verify that the exact target set currently passes. Otherwise cleanup can hide unrelated failures behind a large diff.
+
+## Applied here
+
+- enumerated `*Controller*Test` and `*ControllerTest`
+- ran only those tests first
+- removed them after a successful targeted run
+- rechecked test-source compilation after deletion
+
+## Guardrail
+
+For future bulk test cleanup, identify the exact files, run them in isolation, then delete and verify compilation again.