Prevent absorbing keyword timeout#46
Merged
Merged
Conversation
Owner
Author
|
I did not add a test case for this fix, due to the issue where Robot does not allow you to catch timeouts. the following code snippet does not work, it still fails on the timeout: See also this thread on Slack |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyword timeouts in Robot are triggered by raising a
TimeoutExceededexception. In Robot's exception classes tree this exception is derived from the regularExceptiontype, unlike similar exception types that interrupt user code, likeKeyboardInterruptthat are derived fromBaseException. As a result, some broader exception traps could absorb a timeout exception, failing the keyword to be interrupted and getting stuck. This PR removes too generic catch-all clauses where possible and reraisesTimeoutExceededin situations where unknown exceptions can arise from code outside RobotMBT's control.