TextField: fixed extra margin when leading/trailing component or icon are present#1110
Open
DJ-Raven wants to merge 1 commit intoJFormDesigner:mainfrom
Open
TextField: fixed extra margin when leading/trailing component or icon are present#1110DJ-Raven wants to merge 1 commit intoJFormDesigner:mainfrom
DJ-Raven wants to merge 1 commit intoJFormDesigner:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with TextField margins when using leading/trailing components or icons.
When no layout constraint is set and the JTextField column is 0, the layout uses the component’s preferred size. In this case, an extra horizontal margin becomes visible.
From reviewing the existing implementation, the left and right insets are reduced when leading/trailing components are present, but this is not reflected in the preferred size calculation.
This PR resolves the issue by updating
getPreferredSize(JComponent c)to adjusted insets.Before Fix
After Fix