Skip to content

Commit 16a46d7

Browse files
committed
reordered items in "Insert" menu and toolbar
1 parent f30cac7 commit 16a46d7

3 files changed

Lines changed: 29 additions & 26 deletions

File tree

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Markdown Writer FX Change Log
55

66
- Highlight paragraph in Preview that contain the caret of the editor.
77
- Show source positions for CommonMark in Markdown AST view.
8+
- Reordered items in "Insert" menu and toolbar.
89

910

1011
## 0.6

src/main/java/org/markdownwriterfx/MainWindow.java

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -179,15 +179,9 @@ private Node createMenuBarAndToolBar() {
179179
Action insertStrikethroughAction = new Action(Messages.get("MainWindow.insertStrikethroughAction"), "Shortcut+T", STRIKETHROUGH,
180180
e -> getActiveSmartEdit().insertStrikethrough(Messages.get("MainWindow.insertStrikethroughText")),
181181
activeFileEditorIsNull);
182-
Action insertBlockquoteAction = new Action(Messages.get("MainWindow.insertBlockquoteAction"), "Ctrl+Q", QUOTE_LEFT, // not Shortcut+Q because of conflict on Mac
183-
e -> getActiveSmartEdit().surroundSelection("\n\n> ", ""),
184-
activeFileEditorIsNull);
185182
Action insertCodeAction = new Action(Messages.get("MainWindow.insertCodeAction"), "Shortcut+K", CODE,
186183
e -> getActiveSmartEdit().insertInlineCode(Messages.get("MainWindow.insertCodeText")),
187184
activeFileEditorIsNull);
188-
Action insertFencedCodeBlockAction = new Action(Messages.get("MainWindow.insertFencedCodeBlockAction"), "Shortcut+Shift+K", FILE_CODE_ALT,
189-
e -> getActiveSmartEdit().surroundSelection("\n\n```\n", "\n```\n\n", Messages.get("MainWindow.insertFencedCodeBlockText")),
190-
activeFileEditorIsNull);
191185

192186
Action insertLinkAction = new Action(Messages.get("MainWindow.insertLinkAction"), "Shortcut+L", LINK,
193187
e -> getActiveSmartEdit().insertLink(),
@@ -196,6 +190,19 @@ private Node createMenuBarAndToolBar() {
196190
e -> getActiveSmartEdit().insertImage(),
197191
activeFileEditorIsNull);
198192

193+
Action insertUnorderedListAction = new Action(Messages.get("MainWindow.insertUnorderedListAction"), "Shortcut+U", LIST_UL,
194+
e -> getActiveSmartEdit().insertUnorderedList(),
195+
activeFileEditorIsNull);
196+
Action insertOrderedListAction = new Action(Messages.get("MainWindow.insertOrderedListAction"), "Shortcut+Shift+O", LIST_OL,
197+
e -> getActiveSmartEdit().surroundSelection("\n\n1. ", ""),
198+
activeFileEditorIsNull);
199+
Action insertBlockquoteAction = new Action(Messages.get("MainWindow.insertBlockquoteAction"), "Ctrl+Q", QUOTE_LEFT, // not Shortcut+Q because of conflict on Mac
200+
e -> getActiveSmartEdit().surroundSelection("\n\n> ", ""),
201+
activeFileEditorIsNull);
202+
Action insertFencedCodeBlockAction = new Action(Messages.get("MainWindow.insertFencedCodeBlockAction"), "Shortcut+Shift+K", FILE_CODE_ALT,
203+
e -> getActiveSmartEdit().surroundSelection("\n\n```\n", "\n```\n\n", Messages.get("MainWindow.insertFencedCodeBlockText")),
204+
activeFileEditorIsNull);
205+
199206
Action insertHeader1Action = new Action(Messages.get("MainWindow.insertHeader1Action"), "Shortcut+1", HEADER,
200207
e -> getActiveSmartEdit().insertHeading(1, Messages.get("MainWindow.insertHeader1Text")),
201208
activeFileEditorIsNull);
@@ -215,12 +222,6 @@ private Node createMenuBarAndToolBar() {
215222
e -> getActiveSmartEdit().insertHeading(6, Messages.get("MainWindow.insertHeader6Text")),
216223
activeFileEditorIsNull);
217224

218-
Action insertUnorderedListAction = new Action(Messages.get("MainWindow.insertUnorderedListAction"), "Shortcut+U", LIST_UL,
219-
e -> getActiveSmartEdit().insertUnorderedList(),
220-
activeFileEditorIsNull);
221-
Action insertOrderedListAction = new Action(Messages.get("MainWindow.insertOrderedListAction"), "Shortcut+Shift+O", LIST_OL,
222-
e -> getActiveSmartEdit().surroundSelection("\n\n1. ", ""),
223-
activeFileEditorIsNull);
224225
Action insertHorizontalRuleAction = new Action(Messages.get("MainWindow.insertHorizontalRuleAction"), null, null,
225226
e -> getActiveSmartEdit().surroundSelection("\n\n---\n\n", ""),
226227
activeFileEditorIsNull);
@@ -266,22 +267,23 @@ private Node createMenuBarAndToolBar() {
266267
insertBoldAction,
267268
insertItalicAction,
268269
insertStrikethroughAction,
269-
insertBlockquoteAction,
270270
insertCodeAction,
271-
insertFencedCodeBlockAction,
272271
null,
273272
insertLinkAction,
274273
insertImageAction,
275274
null,
275+
insertUnorderedListAction,
276+
insertOrderedListAction,
277+
insertBlockquoteAction,
278+
insertFencedCodeBlockAction,
279+
null,
276280
insertHeader1Action,
277281
insertHeader2Action,
278282
insertHeader3Action,
279283
insertHeader4Action,
280284
insertHeader5Action,
281285
insertHeader6Action,
282286
null,
283-
insertUnorderedListAction,
284-
insertOrderedListAction,
285287
insertHorizontalRuleAction);
286288

287289
Menu toolsMenu = ActionUtils.createMenu(Messages.get("MainWindow.toolsMenu"),
@@ -305,17 +307,17 @@ private Node createMenuBarAndToolBar() {
305307
null,
306308
insertBoldAction,
307309
insertItalicAction,
308-
insertBlockquoteAction,
309310
insertCodeAction,
310-
insertFencedCodeBlockAction,
311311
null,
312312
insertLinkAction,
313313
insertImageAction,
314314
null,
315-
insertHeader1Action,
316-
null,
317315
insertUnorderedListAction,
318-
insertOrderedListAction);
316+
insertOrderedListAction,
317+
insertBlockquoteAction,
318+
insertFencedCodeBlockAction,
319+
null,
320+
insertHeader1Action);
319321

320322
// horizontal spacer
321323
Region spacer = new Region();

src/main/resources/org/markdownwriterfx/messages.properties

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,15 @@ MainWindow.insertItalicAction=Italic
5757
MainWindow.insertItalicText=emphasized text
5858
MainWindow.insertStrikethroughAction=Strikethrough
5959
MainWindow.insertStrikethroughText=strikethrough text
60-
MainWindow.insertBlockquoteAction=Blockquote
6160
MainWindow.insertCodeAction=Inline Code
6261
MainWindow.insertCodeText=code
63-
MainWindow.insertFencedCodeBlockAction=Fenced Code Block
64-
MainWindow.insertFencedCodeBlockText=enter code here
6562
MainWindow.insertLinkAction=Link...
6663
MainWindow.insertImageAction=Image...
64+
MainWindow.insertUnorderedListAction=Unordered List
65+
MainWindow.insertOrderedListAction=Ordered List
66+
MainWindow.insertBlockquoteAction=Blockquote
67+
MainWindow.insertFencedCodeBlockAction=Fenced Code Block
68+
MainWindow.insertFencedCodeBlockText=enter code here
6769
MainWindow.insertHeader1Action=Header 1
6870
MainWindow.insertHeader1Text=header 1
6971
MainWindow.insertHeader2Action=Header 2
@@ -76,8 +78,6 @@ MainWindow.insertHeader5Action=Header 5
7678
MainWindow.insertHeader5Text=header 5
7779
MainWindow.insertHeader6Action=Header 6
7880
MainWindow.insertHeader6Text=header 6
79-
MainWindow.insertUnorderedListAction=Unordered List
80-
MainWindow.insertOrderedListAction=Ordered List
8181
MainWindow.insertHorizontalRuleAction=Horizontal Rule
8282

8383
MainWindow.toolsMenu=Tools

0 commit comments

Comments
 (0)