ESLint fixes

Author: JamesMessinger

karma.conf.js

@@ -3,6 +3,7 @@
 // https://jstools.dev/karma-config/
 
 "use strict";
+
 const { karmaConfig } = require("@jsdevtools/karma-config");
 const { host } = require("@jsdevtools/host-environment");
 

src/constructor.ts

@@ -9,7 +9,7 @@ export { constructor as Ono };
 /**
  * Creates an `Ono` instance for a specifc error type.
  */
-// tslint:disable-next-line: variable-name
+// eslint-disable-next-line @typescript-eslint/naming-convention
 function Ono<T extends ErrorLike>(ErrorConstructor: ErrorLikeConstructor<T>, options?: OnoOptions) {
   options = normalizeOptions(options);
 

src/extend-error.ts

@@ -27,6 +27,7 @@ export function extendError<T extends ErrorLike, E extends ErrorLike, P extends
   onoError.toJSON = toJSON;
 
   // On Node.js, add support for the `util.inspect()` method
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   if (addInspectMethod) {
     addInspectMethod(onoError);
   }
@@ -69,7 +70,6 @@ function mergeErrors(newError: ErrorLike, originalError: ErrorPOJO) {
 
   // HACK: We have to cast the errors to `any` so we can use symbol indexers.
   // see https://github.com/Microsoft/TypeScript/issues/1863
-  // tslint:disable: no-any no-unsafe-any
   let _newError = newError as any;
   let _originalError = originalError as any;
 

src/index.ts

@@ -1,13 +1,13 @@
+/* eslint-env commonjs */
 import { ono } from "./singleton";
 
 export { Ono } from "./constructor";
 export * from "./types";
 export { ono };
 
-// tslint:disable-next-line: no-default-export
 export default ono;
 
 // CommonJS default export hack
 if (typeof module === "object" && typeof module.exports === "object") {
-  module.exports = Object.assign(module.exports.default, module.exports);  // tslint:disable-line: no-unsafe-any
+  module.exports = Object.assign(module.exports.default, module.exports);
 }

src/isomorphic.node.ts

@@ -19,7 +19,7 @@ export const format = util.format;
  * @see https://nodejs.org/api/util.html#util_util_inspect_custom
  */
 export function addInspectMethod<T>(newError: OnoError<T>): void {
-  // @ts-ignore
+  // @ts-expect-error - TypeScript doesn't support symbol indexers
   newError[inspectMethod] = inspect;
 }
 
@@ -31,7 +31,6 @@ export function addInspectMethod<T>(newError: OnoError<T>): void {
 function inspect<T>(this: OnoError<T>): ErrorPOJO & T {
   // HACK: We have to cast the objects to `any` so we can use symbol indexers.
   // see https://github.com/Microsoft/TypeScript/issues/1863
-  // tslint:disable: no-any no-unsafe-any
   let pojo: any = {};
   let error = this as any;
 
@@ -42,8 +41,8 @@ function inspect<T>(this: OnoError<T>): ErrorPOJO & T {
 
   // Don't include the `inspect()` method on the output object,
   // otherwise it will cause `util.inspect()` to go into an infinite loop
-  delete pojo[inspectMethod];  // tslint:disable-line: no-dynamic-delete
+  // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+  delete pojo[inspectMethod];
 
-  // tslint:enable: no-any no-unsafe-any
   return pojo as ErrorPOJO & T;
 }

src/stack.ts

@@ -1,4 +1,3 @@
-// tslint:disable: no-unbound-method
 import { ErrorLike } from "./types";
 
 const newline = /\r?\n/;
@@ -50,7 +49,7 @@ export function joinStacks(newError: ErrorLike, originalError?: ErrorLike): stri
     return newStack + "\n\n" + originalStack;
   }
   else {
-   return newStack || originalStack;
+    return newStack || originalStack;
   }
 }
 

src/to-json.ts

@@ -11,7 +11,6 @@ const objectPrototype = Object.getPrototypeOf({});
 export function toJSON<E extends ErrorLike>(this: E): ErrorPOJO & E {
   // HACK: We have to cast the objects to `any` so we can use symbol indexers.
   // see https://github.com/Microsoft/TypeScript/issues/1863
-  // tslint:disable: no-any no-unsafe-any
   let pojo: any = {};
   let error = this as any;
 
@@ -26,7 +25,6 @@ export function toJSON<E extends ErrorLike>(this: E): ErrorPOJO & E {
     }
   }
 
-  // tslint:enable: no-any no-unsafe-any
   return pojo as ErrorPOJO & E;
 }
 

src/types.ts

@@ -60,8 +60,7 @@ export interface OnoConstructor {
    * @param originalError - The original error. This error's stack trace will be added to the error's stack trace.
    * @param props - An object whose properties will be added to the error
    */
-  extend<T extends ErrorLike, E extends ErrorLike, P extends object>(error: T, originalError?: E, props?: P)
-  : T & E & P & OnoError<T & E & P>;
+  extend<T extends ErrorLike, E extends ErrorLike, P extends object>(error: T, originalError?: E, props?: P): T & E & P & OnoError<T & E & P>;
 }
 
 /**
@@ -107,8 +106,7 @@ export interface Ono<T extends ErrorLike> {
    * @param message - The new error message, possibly including argument placeholders
    * @param params - Optional arguments to replace the corresponding placeholders in the message
    */
-  <E extends ErrorLike, P extends object>(error: E, props: P, message: string, ...params: unknown[])
-  : T & E & P & OnoError<T & E & P>;
+  <E extends ErrorLike, P extends object>(error: E, props: P, message: string, ...params: unknown[]): T & E & P & OnoError<T & E & P>;
 
   /**
    * Creates an error with a formatted message.

test/specs/format.spec.js

@@ -79,9 +79,7 @@ describe("Error message formatter", () => {
     // A simple formatter that replaces $0, $1, $2, etc. with the corresponding param
     function myCustomFormatter (message) {
       let params = Array.prototype.slice.call(arguments, 1);
-      return params.reduce(function (msg, param, index) {
-        return msg.replace("$" + index, param);
-      }, message);
+      return params.reduce((msg, param, index) => msg.replace("$" + index, param), message);
     }
 
     let myCustomOno = new Ono(SyntaxError, { format: myCustomFormatter });

test/specs/options.spec.js

@@ -215,9 +215,7 @@ describe("Ono options", () => {
       // A simple formatter that replaces $0, $1, $2, etc. with the corresponding param
       function myCustomFormatter (message) {
         let params = Array.prototype.slice.call(arguments, 1);
-        return params.reduce(function (msg, param, index) {
-          return msg.replace("$" + index, param);
-        }, message);
+        return params.reduce((msg, param, index) => msg.replace("$" + index, param), message);
       }
 
       let myCustomOno = new Ono(SyntaxError, {