Bump Castle.Core from 4.4.0 to 5.0.0#152
Conversation
a7720c8 to
384941b
Compare
|
@JSkimming could i help with this |
|
@jzabroski is there a reason you need this? I'd assumed users of this library could update Castle.Core to v5 if you are already targeting .NET 6 or other minimum frameworks referenced by Castle.Core. Upgrading a dependency is a breaking change requiring a major version update. There are a few other breaking changes I was planning on implementing, and to minimise breaking change releases, I intended on combining the two. But if you're held back without this change, then a release just for the Castle.Core update is worth considering. |
|
We're stuck on net48 for one ASP.NET Website project we are porting from WebForms to ASP.NET MVC 5 (and eventually Razor). Your package is insanely important to us since we use it for asynchronous logical transactions, like so: [Transaction(DbContextNames.MyDb)]
public async Task Save()This approach has a downside in that composing two transactions requires both to be annotated, as well as the overarching transaction entry point to be annotated. As a result, we need to inject transactions in the Website Page subclasses. |
|
I would add, our workaround for now is to create a binding redirect (Castle.Core 0.0.0.0-5.0.0.0 => 5.0.0.0), but that seems suboptimal. |
|
I appreciate your situation, having been there myself many times, but binding redirects exist for this reason. I imagine you have many others in your Given this isn't a blocker, I'm keen to stick to my Plan A of bunding the Castle.Core package update with other breaking changes. |
|
Binding redirects aren't autogenerated for Websites, I believe. They are for Web applications instead. |
40083db to
3998ce0
Compare
Bumps [Castle.Core](https://github.com/castleproject/Core) from 4.4.0 to 5.0.0. - [Release notes](https://github.com/castleproject/Core/releases) - [Changelog](https://github.com/castleproject/Core/blob/master/CHANGELOG.md) - [Commits](castleproject/Core@v4.4.0...v5.0.0) --- updated-dependencies: - dependency-name: Castle.Core dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3998ce0 to
2208639
Compare
|
Superseded by #162. |
Bumps Castle.Core from 4.4.0 to 5.0.0.
Release notes
Sourced from Castle.Core's releases.
Changelog
Sourced from Castle.Core's changelog.
Commits
652a250Update changelog773ed6bUpdate changelog for 5.0.0 releasef49b72aReadme: Update conditional compilation symbols51f4f92Merge pull request #616 from Jevonius/add-net6-targets0076083Switch to preprocessor directives to avoid need for System.Runtime.InteropSer...9da21a7Switch SYSLIB0003 suppression to pragma rather than project-level2de4707Update CHANGELOG and README to reflectnet6.0change3e6e22dRemove references of DOTNET462 as no longer used8641c5fUpdate missed copyright header year for changed test file14264bcUpdatePublicApiTestCaseplatform filtering to use NUnit attributeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)