Fix ReturnValue for InterceptSynchronous

[PMExtra]

No description provided.

[PMExtra]

abpframework/abp#9164

[JSkimming]

Hi @PMExtra, I don't know what problem is resolved by this. Can you explain further? Please provide tests that demonstrate the issue and how the change fixes it.

Generally, a transition from async to sync is fraught and best avoided.

[PMExtra]

We have invocation.ReturnValue = InterceptAsync(...) for async methods:
https://github.com/JSkimming/Castle.Core.AsyncInterceptor/blob/v2.1.0/src/Castle.Core.AsyncInterceptor/AsyncInterceptorBase.cs#L49-L67

But we ignored the InterceptAsync result for sync methods.

[PMExtra]

That means we cannot modify the return value for synchronous methods.

[JSkimming]

@PMExtra Can you provide tests as part of your changes that demonstrate the issue?

[PMExtra]

After the patch:

Without the patch:

[PMExtra]

It is also fixed if we want to change the original return value for the synchronous method.

[JSkimming]

@PMExtra, thank you for this. I understand the issue better now. I still want to give this further investigation, and I won't be able to do that for a couple of weeks. I'll be returning to this when I can.