[Junie]: Fix WARN for incorrect completeCiteCommand#725
Closed
github-actions[bot] wants to merge 8 commits into
Closed
[Junie]: Fix WARN for incorrect completeCiteCommand#725github-actions[bot] wants to merge 8 commits into
github-actions[bot] wants to merge 8 commits into
Conversation
Fix WARN for incorrect completeCiteCommand Co-authored-by: koppor <1366654+koppor@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview
It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We'd love your feedback — join our Discord to share bugs, ideas: here.
📊 Junie Summary:
Implemented a warning for invalid cite commands in the external preferences tab.
The following changes were made:
CitationCommandString.from, the log level was upgraded fromINFOtoWARNwhen an invalidcompleteCiteCommandis encountered.FunctionBasedValidatortoExternalTabViewModelthat checks if the cite command contains bothkey1andkey2in the correct order.The cite command should contain '%0' and '%1'.toJabRef_en.properties.citeCommandtext field inExternalTabusingvalidationVisualizer.CITE_KEY1andCITE_KEY2constants public inCitationCommandStringfor use in validation logic.CitationCommandStringTestto cover invalid cite command scenarios and verified they pass.CitationCommandString.