Skip to content

[Junie]: Fix WARN for incorrect completeCiteCommand#725

Closed
github-actions[bot] wants to merge 8 commits into
mainfrom
junie/issue-723-21692290637
Closed

[Junie]: Fix WARN for incorrect completeCiteCommand#725
github-actions[bot] wants to merge 8 commits into
mainfrom
junie/issue-723-21692290637

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Feb 4, 2026

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We'd love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary:

Implemented a warning for invalid cite commands in the external preferences tab.

The following changes were made:

  • Log level changed to WARN: In CitationCommandString.from, the log level was upgraded from INFO to WARN when an invalid completeCiteCommand is encountered.
  • Validation in UI: Added a FunctionBasedValidator to ExternalTabViewModel that checks if the cite command contains both key1 and key2 in the correct order.
  • New Localization String: Added The cite command should contain '%0' and '%1'. to JabRef_en.properties.
  • UI Integration: Connected the validator to the citeCommand text field in ExternalTab using validationVisualizer.
  • Accessibility: Made CITE_KEY1 and CITE_KEY2 constants public in CitationCommandString for use in validation logic.
  • Tests Updated: Added test cases to CitationCommandStringTest to cover invalid cite command scenarios and verified they pass.
  • Code Quality: Ensured checkstyle compliance by adjusting the declaration order of constants in CitationCommandString.

Fix WARN for incorrect completeCiteCommand

Co-authored-by: koppor <1366654+koppor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WARN if wrong completeCiteCommand

2 participants