fix: address static analysis, i18n, and concurrency review findings

Author: Gustavotakehara

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

@@ -211,6 +211,8 @@ private void update() {
                     databaseContext == null ? "null" : databaseContext,
                     entry == null ? "null" : entry,
                     layout == null ? "null" : layout);
+            previewThrottler.cancel();
+            latestRequestId.incrementAndGet();
             setPreviewText("");
             return;
         }
@@ -224,10 +226,19 @@ private void update() {
 
             BackgroundTask.wrap(() -> generatePreviewWithAnnotations(currentEntry, filePreferences))
                           .onSuccess(htmlComplete -> {
-                              if (requestId == latestRequestId.get() && currentEntry.equals(this.entry) && currentDatabaseContext.equals(this.databaseContext) && (currentLayout == null || currentLayout.equals(this.layout))) {
+                              if (requestId == latestRequestId.get()
+                                      && Objects.equals(currentEntry, this.entry)
+                                      && Objects.equals(currentDatabaseContext, this.databaseContext)
+                                      && (currentLayout == null || Objects.equals(currentLayout, this.layout))) {
+
                                   setPreviewText(htmlComplete);
+
+                                  if (preferences.getPreviewPreferences().shouldDownloadCovers()) {
+                                      downloadCoverAndRefresh(currentEntry, htmlComplete);
+                                  }
                               } else {
-                                  LOGGER.debug("Stale preview task discarded for entry: {}", currentEntry.getCitationKey().orElse(""));
+                                  LOGGER.debug("Stale preview task discarded for entry: {}",
+                                          currentEntry != null ? currentEntry.getCitationKey().orElse("") : "");
                               }
                           })
                           .onFailure(exception -> LOGGER.error("Error generating preview text", exception))
@@ -438,8 +449,9 @@ private String generatePreviewWithAnnotations(BibEntry currentEntry, FilePrefere
                 String annotationsHtml = FileAnnotationPreview.render(annotationsMap);
                 previewHtml.append(annotationsHtml);
             }
-        } catch (RuntimeException e) {
-            LOGGER.error("Failed to generate preview with annotations due to a runtime error", e);
+        } catch (Exception e) {
+            LOGGER.error("Failed to read PDF annotations for preview", e);
+            throw new RuntimeException("Error loading PDF annotations", e);
         }
 
         return previewHtml.toString();

jablib/src/main/java/org/jabref/logic/pdf/FileAnnotationPreview.java

@@ -6,14 +6,15 @@
 import java.util.Map;
 import java.util.Objects;
 
+import org.jspecify.annotations.Nullable;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.pdf.FileAnnotation;
 
 import static org.jabref.logic.util.strings.StringUtil.quoteForHTML;
 
 public class FileAnnotationPreview {
-    public static String render(Map<Path, List<FileAnnotation>> annotations) {
+    public static String render(@Nullable Map<Path, List<FileAnnotation>> annotations) {
         if (annotations == null || annotations.isEmpty()) {
             return "";
         }
@@ -45,12 +46,27 @@ public static String render(Map<Path, List<FileAnnotation>> annotations) {
     }
 
     private static void renderAnnotation(StringBuilder html, FileAnnotation annotation) {
-        String type = annotation.getAnnotationType() != null ? annotation.getAnnotationType().toString() : Localization.lang("Unknown");
+        String typeStr;
+
+        if (annotation.getAnnotationType() != null) {
+            String typeName = annotation.getAnnotationType().toString();
+
+            if ("HIGHLIGHT".equalsIgnoreCase(typeName)) {
+                typeStr = Localization.lang("highlight");
+            } else if ("UNDERLINE".equalsIgnoreCase(typeName)) {
+                typeStr = Localization.lang("underline");
+            } else if ("STRIKEOUT".equalsIgnoreCase(typeName)) {
+                typeStr = Localization.lang("strikeout");
+            } else {
+                typeStr = typeName.toLowerCase();
+            }
+        } else {
+            typeStr = Localization.lang("unknown");
+        }
+
         int page = annotation.getPage();
         String content = annotation.getContent();
-
-        String pageLabel = Localization.lang("Page");
-        String headerLabel = "%s (%s %d):".formatted(type, pageLabel, page);
+        String headerLabel = Localization.lang("%0 (page %1)", typeStr, String.valueOf(page));
 
         html.append("<b>")
             .append(quoteForHTML(headerLabel))

jablib/src/main/resources/l10n/JabRef_en.properties

@@ -3592,4 +3592,8 @@ The\ format\ option\ must\ contain\ either\ 'xmp'\ or\ 'bibtex-attachment'.=The
 
 Note=Note
 PDF\ Annotations=PDF Annotations
-Unknown=Unknown
+unknown=unknown
+highlight=highlight
+strikeout=strikeout
+underline=underline
+%0\ (page\ %1)=%0 (page %1)