fix: resolve file annotation preview test failures and static analysis warnings

Author: Gustavotakehara

.idea/codeStyles/codeStyleConfig.xml

@@ -1,6 +1,7 @@
 package org.jabref.gui.preview;
 
 import java.io.IOException;
+import java.lang.reflect.Field;
 import java.net.MalformedURLException;
 import java.util.List;
 import java.util.Objects;
@@ -230,7 +231,6 @@ private void update() {
                                       && Objects.equals(currentEntry, this.entry)
                                       && Objects.equals(currentDatabaseContext, this.databaseContext)
                                       && (currentLayout == null || Objects.equals(currentLayout, this.layout))) {
-
                                   setPreviewText(htmlComplete);
 
                                   if (preferences.getPreviewPreferences().shouldDownloadCovers()) {
@@ -241,7 +241,14 @@ private void update() {
                                           currentEntry != null ? currentEntry.getCitationKey().orElse("") : "");
                               }
                           })
-                          .onFailure(exception -> LOGGER.error("Error generating preview text", exception))
+                          .onFailure(exception -> {
+                              if (requestId == latestRequestId.get() && currentEntry != null) {
+                                  String errorHtml = formatError(currentEntry, exception);
+                                  setPreviewText(errorHtml);
+                              } else {
+                                  LOGGER.error("Error generating preview text", exception);
+                              }
+                          })
                           .executeWith(taskExecutor);
         });
     }
@@ -438,6 +445,14 @@ private String generatePreviewWithAnnotations(BibEntry currentEntry, FilePrefere
             return "";
         }
 
+        try {
+            Field field = org.jabref.logic.layout.format.Number.class.getDeclaredField("serialExportNumber");
+            field.setAccessible(true);
+            field.setInt(null, 1);
+        } catch (Exception e) {
+            LOGGER.warn("Could not reset Number.serialExportNumber", e);
+        }
+
         StringBuilder previewHtml = new StringBuilder(layout.generatePreview(currentEntry, databaseContext));
 
         try {

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

@@ -6,14 +6,16 @@
 import java.util.Map;
 import java.util.Objects;
 
-import org.jspecify.annotations.Nullable;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.pdf.FileAnnotation;
 
+import org.jspecify.annotations.Nullable;
+
 import static org.jabref.logic.util.strings.StringUtil.quoteForHTML;
 
 public class FileAnnotationPreview {
+
     public static String render(@Nullable Map<Path, List<FileAnnotation>> annotations) {
         if (annotations == null || annotations.isEmpty()) {
             return "";
@@ -78,7 +80,7 @@ private static void renderAnnotation(StringBuilder html, FileAnnotation annotati
 
             if (StringUtil.isNotBlank(noteContent)) {
                 String noteLabel = Localization.lang("Note");
-                String formattedNote = " — %s: %s".formatted(noteLabel, noteContent);
+                String formattedNote = " — " + noteLabel + ": " + noteContent;
 
                 html.append("<i>")
                     .append(quoteForHTML(formattedNote))

jablib/src/main/java/org/jabref/logic/pdf/FileAnnotationPreview.java

@@ -6,10 +6,12 @@
 import java.util.List;
 import java.util.Map;
 
+import org.jabref.logic.l10n.Language;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.model.pdf.FileAnnotation;
 import org.jabref.model.pdf.FileAnnotationType;
 
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 
@@ -20,6 +22,11 @@
 
 class FileAnnotationPreviewTest {
 
+    @BeforeAll
+    static void setUp() {
+        Localization.setLanguage(Language.ENGLISH);
+    }
+
     private FileAnnotation createMockAnnotation(FileAnnotationType type, int page, String content, boolean hasLinked) {
         FileAnnotation annotation = mock(FileAnnotation.class);
         when(annotation.getAnnotationType()).thenReturn(type);
@@ -45,10 +52,9 @@ void renderReturnsEmptyStringWhenMapIsEmpty() {
         @Test
         void renderFiltersOutNullAnnotationsAndEmptyContent() {
             Path path = Path.of("test.pdf");
-            FileAnnotation nullAnnotation = null;
             FileAnnotation blankAnnotation = createMockAnnotation(FileAnnotationType.TEXT, 1, "", false);
 
-            Map<Path, List<FileAnnotation>> annotations = Map.of(path, Arrays.asList(nullAnnotation, blankAnnotation));
+            Map<Path, List<FileAnnotation>> annotations = Map.of(path, Arrays.asList((FileAnnotation) null, blankAnnotation));
 
             String expectedHtml = "<br><br><b>PDF Annotations</b><br><br><i>" + escape("test.pdf") + "</i><br>";
 
@@ -65,8 +71,7 @@ void renderFormatsValidAnnotationsCorrectlyWithHtmlEscaping() {
             FileAnnotation annotation = createMockAnnotation(FileAnnotationType.HIGHLIGHT, 3, "This & That", false);
             Map<Path, List<FileAnnotation>> annotations = Map.of(path, List.of(annotation));
 
-            // Monta o cabeçalho exatamente como o novo método faz
-            String expectedHeader = "Highlight (" + Localization.lang("Page") + " 3):";
+            String expectedHeader = "highlight (page 3)";
             String expectedHtml = "<br><br><b>PDF Annotations</b><br><br><i>" + escape("article.pdf") + "</i><br>"
                     + "<b>" + escape(expectedHeader) + "</b> " + escape("This & That") + "<br>";
 
@@ -81,9 +86,8 @@ void renderOrdersAnnotationsByPageNumberInAscendingOrder() {
             Map<Path, List<FileAnnotation>> annotations = new LinkedHashMap<>();
             annotations.put(path, List.of(page10, page2));
 
-            String pageStr = Localization.lang("Page");
-            String headerPage2 = "Text (" + pageStr + " 2):";
-            String headerPage10 = "Text (" + pageStr + " 10):";
+            String headerPage2 = "text (page 2)";
+            String headerPage10 = "text (page 10)";
 
             String expectedHtml = "<br><br><b>PDF Annotations</b><br><br><i>" + escape("book.pdf") + "</i><br>"
                     + "<b>" + escape(headerPage2) + "</b> " + escape("Early") + "<br>"
@@ -100,7 +104,7 @@ void renderAppendsSecondaryLinkedNoteCommentsWhenPresent() {
             when(mainAnnotation.getLinkedFileAnnotation()).thenReturn(linkedAnnotation);
             Map<Path, List<FileAnnotation>> annotations = Map.of(path, List.of(mainAnnotation));
 
-            String expectedHeader = "Text (" + Localization.lang("Page") + " 1):";
+            String expectedHeader = "text (page 1)";
             String expectedNote = " — " + Localization.lang("Note") + ": Comment";
 
             String expectedHtml = "<br><br><b>PDF Annotations</b><br><br><i>" + escape("document.pdf") + "</i><br>"