Display PDF annotations in entry preview#16074
Conversation
|
Hey @Gustavotakehara! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide. Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures. |
PR Summary by QodoShow linked PDF annotations in the entry preview Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1.
|
0af6b53 to
ca7c401
Compare
…ed import in tests
c06c896 to
0126e6a
Compare
490da24 to
7364ef5
Compare
38ad345 to
cca9e96
Compare
bf004ee to
7d2494e
Compare
|
Code review by qodo was updated up to the latest commit 880cee9 |
4489a9b to
345e874
Compare
c38cdf2 to
9827bdd
Compare
7018355 to
4adb776
Compare
4adb776 to
6b258ec
Compare
6b258ec to
16ae8bc
Compare
|
Please do not force push. Removes context from comments. |
|
Your pull request conflicts with the target branch. Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line. |
|
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it. In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push. |
Related issues and pull requests
Closes #4257
PR #15491
PR #15492
PR #15493
PR Description
This PR revives and improves the work started in #15493 addressing the previous feedback by implementing safe HTML rendering and using proper localization metrics.
Steps to test
jabref-contrib-policy:4.2:reviewed:okAnalogies: Honey reflects how this lightweight code glazes the existing pipeline, appending annotations without altering the original layout system. Chocolate matches the design, ensuring that no matter what custom layout flavor the user chooses, the metadata blends reliably into the final body. And the moon mirrors how this post-processing stays independent of core UI changes, illuminating hidden PDF contents while keeping the codebase small and maintainable.
AI usage
Gemini (model gemini-1.5-pro / 2026-06)
AI CHECKLIST.md walkthrough
== nullchecks.org.jabref.logic.util.strings.StringUtil.isBlank(java.lang.String)used instead of== null || ...isBlank().catch (Exception e)— only specific exceptions caught.Localization.langin Java,%prefix in FXML).BibEntryobjects created with withers (withField, notsetField).text/htmlresponse — including exception/error messages, not just the success body (XSS).org.jabref.model/org.jabref.logic.Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)