Skip to content

Add hyperlink in ADR#16199

Merged
Siedlerchr merged 1 commit into
JabRef:mainfrom
pluto-han:Add-ADR
Jul 8, 2026
Merged

Add hyperlink in ADR#16199
Siedlerchr merged 1 commit into
JabRef:mainfrom
pluto-han:Add-ADR

Conversation

@pluto-han

Copy link
Copy Markdown
Collaborator

Related issues and pull requests

Follow-up #15907

PR Description

Add hyperlink

Steps to test

AI usage

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] If AI tools were used, I disclosed them in the "AI usage" section and reviewed, understood, and take full ownership of all AI-generated code
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [.] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [.] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add Zotero item type hyperlink to ADR 0064

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Link Zotero “item types” reference in ADR 0064 for quicker context lookup.
• Improve traceability of the mapping discussion by pointing to canonical Zotero docs.
High-Level Assessment

The chosen approach (linking directly to Zotero’s canonical “item types and fields” documentation) is the simplest and most maintainable option; alternatives like footnotes or a local copy would add maintenance overhead without clear benefit.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
0064-use-citation-js-mapping.mdAdd Zotero item types link in context statement +1/-1

Add Zotero item types link in context statement

• Replaces the plain text reference to Zotero item types with a hyperlink to Zotero’s official “item types and fields” documentation, improving navigability for readers of the ADR.

docs/decisions/0064-use-citation-js-mapping.md

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@jabref-machine

Copy link
Copy Markdown
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of - [x] (done), - [ ] (yet to be done) or - [/] (not applicable). Please adhere to our pull request template.

@jabref-machine

Copy link
Copy Markdown
Collaborator

Your code currently does not meet JabRef's code guidelines. We use Gradle Modernizer Plugin to ensure "modern" Java coding practices. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Modernizer (pull_request)" and click on it.

Please fix the detected errors, commit, and push.

@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Jul 8, 2026
@koppor

koppor commented Jul 8, 2026

Copy link
Copy Markdown
Member

Diff looks good, but commit seems not to be done on upstatem/main. Maybe reset and forve push?

@pluto-han

Copy link
Copy Markdown
Collaborator Author

Diff looks good, but commit seems not to be done on upstatem/main. Maybe reset and forve push?

Updated. I forgot to create a new branch...

@Siedlerchr
Siedlerchr enabled auto-merge July 8, 2026 11:35
@Siedlerchr
Siedlerchr added this pull request to the merge queue Jul 8, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Jul 8, 2026
Merged via the queue into JabRef:main with commit dcb5897 Jul 8, 2026
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants