Add option to hide access-key markers (&) in menu names#135
Merged
Conversation
Jack251970
requested changes
Apr 22, 2026
Owner
Jack251970
left a comment
There was a problem hiding this comment.
Could you please resolve the merge conflicts?
# Conflicts: # ContextMenuManager/Methods/AppConfig.cs # ContextMenuManager/Methods/AppString.cs # ContextMenuManager/Properties/Resources/Texts/AppLanguageDic.ini # ContextMenuManager/Views/AppSettingView.xaml # ContextMenuManager/Views/AppSettingView.xaml.cs # languages/en-US.ini # languages/zh-CN.ini
Puts "Hide access-key markers" next to "Hide disabled items" and "Hide system store items", so the three Hide* rows cluster by shared intent. Dim inferred icons moves to the end.
Author
|
Conflicts resolved on the latest push, ready for another look. One small note: while merging upstream I also moved the |
Jack251970
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StripMenuMnemonicssetting (off by default) that strips Win32 access-key&markers from displayed menu item names and collapses&&to a literal&, so the list matches what Explorer renders.Textfrom registry/XML sources across shell, shellex, shellnew, sendto, winx, openwith, IE, UWP, rule, and guid-blocked items, plusEnhanceMenuListandDetailedEditList.AppSettingView, with en-US and zh-CN strings.ItemTextrather than the stripped display text, so mnemonics are preserved on save.The toggle does not need to trigger an explicit refresh: the setting is only reachable via the Settings page, and
MainWindow.NavigateToclears and rebuilds any list on navigation, which re-runs the strip on everyTextassignment. TheGuidInfo.ItemTextDiccache holds raw pre-strip text, so stripping is reapplied on each rebuild regardless of cache state.SearchService.Initializeis called fromLoadItems, so search snapshots also refresh.Test plan
&(e.g.&Open,Cu&t) display unchanged.&is removed and&&collapses to one&.&and saving preserves it.