Skip to content

Commit c56f36d

Browse files
authored
Merge pull request #35 from seansfkelley/urlencode-everything
Manually URL re-encode everything so pluses and other regex characters survive.
2 parents 1f28586 + ef138e6 commit c56f36d

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

Sources/ScryfallKit/Networking/EndpointRequests/EndpointRequest.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ protocol EndpointRequest {
1515
extension EndpointRequest {
1616
var urlRequest: URLRequest? {
1717
var urlComponents = URLComponents(string: "https://api.scryfall.com/\(path)")
18-
if !queryParams.isEmpty {
19-
urlComponents?.queryItems = queryParams.compactMap { $0.value == nil ? nil : $0 }
18+
urlComponents?.queryItems = queryParams.compactMap { $0.value == nil ? nil : $0 }
19+
let queryItems = urlComponents?.queryItems
20+
urlComponents?.percentEncodedQueryItems = queryItems?.map {
21+
URLQueryItem(name: $0.name, value: $0.value?.addingPercentEncoding(withAllowedCharacters: .alphanumerics))
2022
}
2123

2224
guard let url = urlComponents?.url else {

0 commit comments

Comments
 (0)