fix(ci): harden mirror bootstrap release smoke

Author: Jacobinwwey

.github/workflows/release-desktop-multi-os.yml

@@ -81,6 +81,7 @@ jobs:
             echo "Godot mirror release already exists: $GODOT_MIRROR_TAG"
           else
             gh release create "$GODOT_MIRROR_TAG" \
+              --target "$GITHUB_SHA" \
               --title "$GODOT_MIRROR_TAG" \
               --notes "Project-controlled mirror for Godot desktop bootstrap archives."
           fi

scripts/tauri-sidecar-utils.js

@@ -430,14 +430,19 @@ function validateTauriSidecars(options = {}) {
   const repoRoot = options.repoRoot || path.resolve(__dirname, '..');
   const platform = options.platform || process.platform;
   const arch = options.arch || process.arch;
+  const env = options.env || process.env;
   const validateAll = options.validateAll === true;
   const binDir = path.join(repoRoot, 'src-tauri', 'bin');
 
   const requiredServerBinaryNames = validateAll
     ? [SERVER_BINARIES.windows_x64, SERVER_BINARIES.linux_x64, SERVER_BINARIES.macos_arm64]
     : [resolveHostServerBinaryName({ platform, arch })].filter(Boolean);
   const requiredMarkdownWorkerBinaryNames = [resolveHostMarkdownWorkerBinaryName({ platform, arch })].filter(Boolean);
-  const requiredGodotBinaryNames = [resolveHostGodotBinaryName({ platform, arch })].filter(Boolean);
+  const requiredGodotBinaryNames = validateAll
+    ? [HOST_GODOT_BINARY.windows_x64].filter(Boolean)
+    : shouldFailOnMissing({ platform, env })
+      ? [resolveHostGodotBinaryName({ platform, arch })].filter(Boolean)
+      : [];
 
   const invalid = [];
 

src/godot.sidecar.bootstrap.contract.test.ts

@@ -41,6 +41,7 @@ type SidecarUtilsModule = {
     platform?: string;
     arch?: string;
     validateAll?: boolean;
+    env?: Record<string, string | undefined>;
   }) => ValidateSidecarsResult;
 };
 
@@ -233,15 +234,11 @@ describe('godot sidecar bootstrap contracts', () => {
     ).rejects.toThrow(/sha256/i);
   });
 
-  test('validates the host-specific godot binary name together with server and markdown worker sidecars', () => {
+  test('does not require a linux host godot binary by default when validating sidecars', () => {
     const fakeRepoRoot = temp.mkdir('repo');
     const binDir = temp.mkdir(path.join('repo', 'src-tauri', 'bin'));
     fs.writeFileSync(path.join(binDir, 'server-x86_64-unknown-linux-gnu'), 'server');
     fs.writeFileSync(path.join(binDir, 'markdown-worker-x86_64-unknown-linux-gnu'), 'worker');
-    fs.writeFileSync(
-      path.join(binDir, 'godot-x86_64-unknown-linux-gnu'),
-      Buffer.alloc(sidecarUtils.MIN_GODOT_BINARY_BYTES + 8, 5)
-    );
 
     const result = sidecarUtils.validateTauriSidecars({
       repoRoot: fakeRepoRoot,
@@ -255,6 +252,36 @@ describe('godot sidecar bootstrap contracts', () => {
     expect(result.invalid).toEqual([]);
   });
 
+  test('requires the windows host godot binary together with server and markdown worker sidecars', () => {
+    const fakeRepoRoot = temp.mkdir('repo');
+    const binDir = temp.mkdir(path.join('repo', 'src-tauri', 'bin'));
+    fs.writeFileSync(path.join(binDir, 'server-x86_64-pc-windows-msvc.exe'), 'server');
+    fs.writeFileSync(path.join(binDir, 'markdown-worker-x86_64-pc-windows-msvc.exe'), 'worker');
+
+    const missingGodot = sidecarUtils.validateTauriSidecars({
+      repoRoot: fakeRepoRoot,
+      platform: 'win32',
+      arch: 'x64',
+    });
+
+    expect(missingGodot.invalid).toEqual([
+      expect.stringContaining('godot-x86_64-pc-windows-msvc.exe'),
+    ]);
+
+    fs.writeFileSync(
+      path.join(binDir, 'godot-x86_64-pc-windows-msvc.exe'),
+      Buffer.alloc(sidecarUtils.MIN_GODOT_BINARY_BYTES + 8, 5)
+    );
+
+    const ready = sidecarUtils.validateTauriSidecars({
+      repoRoot: fakeRepoRoot,
+      platform: 'win32',
+      arch: 'x64',
+    });
+
+    expect(ready.invalid).toEqual([]);
+  });
+
   test('treats git-lfs pointer placeholders as invalid server and markdown-worker sidecars', () => {
     const fakeRepoRoot = temp.mkdir('repo');
     const binDir = temp.mkdir(path.join('repo', 'src-tauri', 'bin'));
@@ -266,11 +293,6 @@ describe('godot sidecar bootstrap contracts', () => {
 
     fs.writeFileSync(path.join(binDir, 'server-x86_64-unknown-linux-gnu'), lfsPointer);
     fs.writeFileSync(path.join(binDir, 'markdown-worker-x86_64-unknown-linux-gnu'), lfsPointer);
-    fs.writeFileSync(
-      path.join(binDir, 'godot-x86_64-unknown-linux-gnu'),
-      Buffer.alloc(sidecarUtils.MIN_GODOT_BINARY_BYTES + 8, 5)
-    );
-
     const result = sidecarUtils.validateTauriSidecars({
       repoRoot: fakeRepoRoot,
       platform: 'linux',

src/release.godot.mirror.contract.test.ts

@@ -15,6 +15,8 @@ describe('release workflow godot mirror contract', () => {
 
     expect(workflow).toContain('GODOT_MIRROR_TAG: "godot-mirror-v4.3-stable"');
     expect(workflow).toContain('ensure-godot-mirror-assets:');
+    expect(workflow).toContain('gh release create "$GODOT_MIRROR_TAG" \\');
+    expect(workflow).toContain('--target "$GITHUB_SHA" \\');
     expect(workflow).toContain('gh release upload "$GODOT_MIRROR_TAG"');
     expect(workflow).toContain(
       'https://github.com/Jacobinwwey/NoteConnection/releases/download/${GODOT_MIRROR_TAG}'