Skip to content

Commit bb27e34

Browse files
Jacobinwweyclaude
andcommitted
fix: resolve all 27 remaining tsc type errors to achieve zero-error baseline
- Add pendingVerificationCount to sessionActionTelemetry in types.ts - Add queryRelationPathCoverageRatioPct etc. to LearningQualitySnapshot - Add autoPromoteMemory fields to StudySessionActionExecutionRequest - Add pathStrategy fields to StudySessionPlanExecutionRequest - Allow options param in createFileGraphDbSnapshotAdapter/createGraphDbSnapshotAdapter - Widen KnowledgeLearningPlatformOptions: graphQueryBackend, tutorRoutingConfig, trendRuntimeConfig - Add getRendererRuntimeAvailability to MarkdownGatewayOptions - Add explicit any annotations for implicit params in store.test.ts and server.ts - Fix symbol index type errors in server.ts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 409a451 commit bb27e34

6 files changed

Lines changed: 36 additions & 18 deletions

File tree

src/learning/KnowledgeLearningPlatform.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,16 @@ export type KnowledgeLearningPlatformOptions = {
125125
studySessionPlanQualityAdaptiveThresholdsEnabled?: boolean;
126126
studySessionPlanQualityAdaptiveThresholdRuntimeConfig?: Record<string, number>;
127127
graphQueryBackendFactoryOptions?: Record<string, unknown>;
128+
graphQueryBackend?: any;
128129
tutorAdapters?: any[];
129130
localVectorIndexPath?: string;
130131
localVectorAnnPrefilterEnabled?: boolean;
131132
localVectorAccelerationAdapter?: string;
132133
localVectorAccelerationFailureMode?: string;
133134
localVectorAccelerationRepresentationStrict?: boolean;
134-
studySessionOrchestrationTrendRuntimeConfig?: Record<string, number>;
135+
studySessionOrchestrationTrendRuntimeConfig?: Record<string, unknown>;
135136
studySessionOrchestrationMemorySignalConfig?: Record<string, number>;
136-
studySessionOrchestrationTutorRoutingConfig?: Record<string, number>;
137+
studySessionOrchestrationTutorRoutingConfig?: Record<string, unknown>;
137138
}
138139

139140
const STOPWORDS = new Set<string>([

src/learning/store.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ describe('Knowledge graph store backend factory', () => {
324324
async loadSnapshot() {
325325
return persisted;
326326
},
327-
async saveSnapshot(snapshot) {
327+
async saveSnapshot(snapshot: any) {
328328
persisted = snapshot;
329329
},
330330
getDiagnostics() {
@@ -403,7 +403,7 @@ describe('Knowledge graph store backend factory', () => {
403403
loadOpsCount += 1;
404404
return persisted;
405405
},
406-
async saveSnapshotByOps(snapshot) {
406+
async saveSnapshotByOps(snapshot: any) {
407407
saveOpsCount += 1;
408408
persisted = snapshot;
409409
},
@@ -474,7 +474,7 @@ describe('Knowledge graph store backend factory', () => {
474474
loadCount += 1;
475475
return persisted;
476476
},
477-
async saveSnapshot(snapshot) {
477+
async saveSnapshot(snapshot: any) {
478478
saveCount += 1;
479479
persisted = snapshot;
480480
},
@@ -540,7 +540,7 @@ describe('Knowledge graph store backend factory', () => {
540540
loadSnapshotCount += 1;
541541
return persisted;
542542
},
543-
async saveSnapshot(snapshot) {
543+
async saveSnapshot(snapshot: any) {
544544
saveSnapshotCount += 1;
545545
persisted = snapshot;
546546
},
@@ -594,7 +594,7 @@ describe('Knowledge graph store backend factory', () => {
594594
loadCount += 1;
595595
return persisted;
596596
},
597-
async saveSnapshot(snapshot) {
597+
async saveSnapshot(snapshot: any) {
598598
saveCount += 1;
599599
persisted = snapshot;
600600
},

src/learning/store.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ export function createFileBackedKnowledgeGraphStore(options: FileBackedKnowledge
170170
return new FileBackedKnowledgeGraphStore(options);
171171
}
172172
export type GraphDbSnapshotAdapter = any;
173-
export const createFileGraphDbSnapshotAdapter = () => ({}) as any;
174-
export const createGraphDbSnapshotAdapter = () => ({}) as any;
173+
export const createFileGraphDbSnapshotAdapter = (_options?: any) => ({}) as any;
174+
export const createGraphDbSnapshotAdapter = (_options?: any) => ({}) as any;
175175
export const normalizeGraphDbSnapshotAdapterProvider = (v: any) => v;
176176
export const normalizeGraphDbStoreOperationMode = (v: any) => v;
177177
export const normalizeKnowledgeGraphStoreBackend = (v: any) => v;

src/learning/types.ts

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,10 @@ export interface StudySessionActionExecutionRequest {
384384
tutorAdapterId?: string;
385385
tutorProviderName?: string;
386386
tutorProviderMode?: string;
387+
autoPromoteMemory?: boolean;
388+
promoteMemoryTargetLayer?: MemoryLayer;
389+
promoteMemoryMinConfidence?: number;
390+
promoteMemoryRemoveFromSource?: boolean;
387391
}
388392

389393
export interface StudySessionActionExecutionResponse {
@@ -424,7 +428,13 @@ export interface StudySessionPlanExecutionRequest {
424428
executedAt?: string;
425429
tutorAdapterId?: string;
426430
tutorProviderName?: string;
427-
tutorProviderMode?: string;
431+
tutorProviderMode?: string;
432+
pathStrategy?: string;
433+
pathRecommendedActionLimit?: number;
434+
autoPromoteMemory?: boolean;
435+
promoteMemoryTargetLayer?: MemoryLayer;
436+
promoteMemoryMinConfidence?: number;
437+
promoteMemoryRemoveFromSource?: boolean;
428438
}
429439

430440
export interface StudySessionPlanExecutionItem {
@@ -630,6 +640,7 @@ export interface KnowledgeSystemState {
630640
memoryPromotionCount?: number;
631641
memoryPromotionAppliedCount?: number;
632642
verifiedTutorCount?: number;
643+
pendingVerificationCount?: number;
633644
outcomeCounts: {
634645
correct: number;
635646
partial: number;
@@ -647,7 +658,7 @@ export interface KnowledgeSystemState {
647658
totalSessions: number;
648659
totalRecords?: number;
649660
strategyBreakdown?: Record<string, number>;
650-
strategyRecords?: Record<string, number>;
661+
strategyRecords?: number;
651662
selectionSourceCounts?: Record<string, number>;
652663
selectionSourcePositiveRatioPct?: Record<string, number>;
653664
selectionSourceAverageMasteryDeltaPct?: Record<string, number>;
@@ -677,6 +688,11 @@ export interface LearningQualitySnapshot {
677688
pathStrategyExecutionCoveragePct?: number;
678689
pathStrategyAverageMasteryDeltaPct?: number;
679690
queryEvidenceCoverageRatioPct?: number;
691+
queryRelationPathCoverageRatioPct?: number;
692+
queryTemporalValidityPassRatioPct?: number;
693+
pendingVerificationRatioPct?: number;
694+
queryBackendFallbackRatioPct?: number;
695+
sessionMemoryPromotionCoveragePct?: number;
680696
}
681697

682698
export interface LearningQualitySnapshotRequest {

src/markdown/MarkdownGateway.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ type MarkdownGatewayOptions = {
139139
projectRoot: string;
140140
getKnowledgeBaseRoot: () => Promise<string> | string;
141141
resolveMarkdownPath: (rawPath: string) => Promise<string>;
142+
getRendererRuntimeAvailability?: () => Promise<{ graphvizBackendPngAvailable: boolean }>;
142143
logger?: Logger;
143144
};
144145

src/server.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7743,7 +7743,7 @@ async function buildKnowledgeRuntimePayload(generatedAt: string): Promise<Knowle
77437743
averageProviderAttemptCount: tutorTraceDiagnostics.summary?.averageProviderAttemptCount,
77447744
},
77457745
providerBreakdown: Array.isArray(tutorTraceDiagnostics.providerBreakdown)
7746-
? tutorTraceDiagnostics.providerBreakdown.map((item) => ({
7746+
? tutorTraceDiagnostics.providerBreakdown.map((item: any) => ({
77477747
providerName: item.providerName,
77487748
traces: item.traces,
77497749
fallbackTraces: item.fallbackTraces,
@@ -7771,7 +7771,7 @@ async function buildKnowledgeRuntimePayload(generatedAt: string): Promise<Knowle
77717771
recommendedFocusProviderName: tutorProviderTrendHistory.summary?.recommendedFocusProviderName,
77727772
},
77737773
records: Array.isArray(tutorProviderTrendHistory.records)
7774-
? tutorProviderTrendHistory.records.map((item) => ({
7774+
? tutorProviderTrendHistory.records.map((item: any) => ({
77757775
providerName: item.providerName,
77767776
windowIndex: item.windowIndex,
77777777
sampleCount: item.sampleCount,
@@ -7798,7 +7798,7 @@ async function buildKnowledgeRuntimePayload(generatedAt: string): Promise<Knowle
77987798
recommendedFocusReason: tutorProviderTrendDiagnostics.summary?.recommendedFocusReason,
77997799
},
78007800
providers: Array.isArray(tutorProviderTrendDiagnostics.providers)
7801-
? tutorProviderTrendDiagnostics.providers.map((item) => ({
7801+
? tutorProviderTrendDiagnostics.providers.map((item: any) => ({
78027802
providerName: item.providerName,
78037803
trendStatus: item.trendStatus,
78047804
trendScore: item.trendScore,
@@ -8955,7 +8955,7 @@ function resolveStudySessionPlanQualityThresholdOverridesFromEnv(
89558955
mappings.forEach(([key, envKey]) => {
89568956
const parsed = parseFiniteNumberOrUndefined(env[envKey]);
89578957
if (typeof parsed === 'number') {
8958-
overrides[key] = parsed;
8958+
overrides[key as string] = parsed;
89598959
}
89608960
});
89618961
return overrides;
@@ -10771,7 +10771,7 @@ function normalizeStudySessionPlanQualityThresholdOverrides(
1077110771
mappings.forEach(([key, keys]) => {
1077210772
const parsed = parseFiniteNumberOrUndefined(readFirstPresentValue(record, keys));
1077310773
if (typeof parsed === 'number') {
10774-
output[key] = parsed;
10774+
output[key as string] = parsed;
1077510775
}
1077610776
});
1077710777
return Object.keys(output).length > 0 ? output : undefined;
@@ -10957,7 +10957,7 @@ function normalizeStudySessionOrchestrationConfigPatch(
1095710957
trendMappings.forEach(([key, keys]) => {
1095810958
const parsed = parsePositiveIntegerValue(readFirstPresentValue(trendRuntimeConfigRecord, keys));
1095910959
if (parsed > 0) {
10960-
(trendRuntimeConfig as Record<string, unknown>)[key] = parsed;
10960+
(trendRuntimeConfig as Record<string, unknown>)[key as string] = parsed;
1096110961
}
1096210962
});
1096310963
const strategyAutoPathEnabled = parseBooleanFlagOrUndefined(
@@ -10993,7 +10993,7 @@ function normalizeStudySessionOrchestrationConfigPatch(
1099310993
memoryMappings.forEach(([key, keys]) => {
1099410994
const parsed = parseFiniteNumberOrUndefined(readFirstPresentValue(memorySignalConfigRecord, keys));
1099510995
if (typeof parsed === 'number') {
10996-
memorySignalConfig[key] = parsed;
10996+
memorySignalConfig[key as string] = parsed;
1099710997
}
1099810998
});
1099910999

0 commit comments

Comments
 (0)