fix(eslint-plugin-next): respect pageExtensions in no-html-link-for-pages rule#2
Closed
Jah-yee wants to merge 3 commits into
Closed
fix(eslint-plugin-next): respect pageExtensions in no-html-link-for-pages rule#2Jah-yee wants to merge 3 commits into
Jah-yee wants to merge 3 commits into
Conversation
…ages rule The no-html-link-for-pages rule was using hardcoded regex patterns /(\.(j|t)sx?)$/ to detect page files, ignoring the pageExtensions configured in next.config.js. This change: - Reads pageExtensions from context.settings.next.pageExtensions - Passes pageExtensions to getUrlFromPagesDirectories and getUrlFromAppDirectory - Updates parseUrlForPages and parseUrlForAppDir to build dynamic regex patterns from the configured extensions - Defaults to ['jsx', 'js', 'ts', 'tsx'] when no pageExtensions is set Fixes vercel#53473
Owner
Author
|
Closing this internal fork PR to tidy the queue; the upstream PR is the one to track. Happy to reopen here if a fork-only workflow is ever needed. Upstream: vercel#92980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The
@next/next/no-html-link-for-pagesrule was ignoring thepageExtensionsconfiguration fromnext.config.js, causing false negatives when users configured custom page extensions (e.g.,page.tsx,page.ts).Root Cause
In
packages/eslint-plugin-next/src/utils/url.ts, theparseUrlForPagesandparseUrlForAppDirfunctions used hardcoded regex/(\\.(j|t)sx?)$/to detect page files, instead of using the configuredpageExtensions.Changes
url.ts:parseUrlForPagesnow accepts apageExtensionsparameter and builds a dynamic regex from itparseUrlForAppDirsimilarly respectspageExtensionsforpage.tsxandlayout.tsxdetectiongetUrlFromPagesDirectoriesandgetUrlFromAppDirectorynow accept and passpageExtensions['jsx', 'js', 'ts', 'tsx']for backward compatibilityno-html-link-for-pages.ts:pageExtensionsfromcontext.settings.next.pageExtensionsgetUrlFromPagesDirectoriesandgetUrlFromAppDirectoryUsage
In your ESLint config:
Closes vercel#53473