fix(eslint-plugin-next): support custom pageExtensions in no-html-link-for-pages rule#3
Closed
Jah-yee wants to merge 2 commits into
Closed
fix(eslint-plugin-next): support custom pageExtensions in no-html-link-for-pages rule#3Jah-yee wants to merge 2 commits into
Jah-yee wants to merge 2 commits into
Conversation
Owner
Author
|
Closing this internal fork PR to tidy the queue; the upstream PR is the one to track. Happy to reopen here if a fork-only workflow is ever needed. Upstream: vercel#92980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Problem
The
@next/next/no-html-link-for-pagesESLint rule was not working when users configured custompageExtensionsin theirnext.config.js. The rule was hardcoded to only detect standard JS/TS extensions.Solution
This fix reads
pageExtensionsfromcontext.settings.next.pageExtensionsin the ESLint config and passes it to theparseUrlForPagesfunction. It falls back to default extensions['tsx','ts','jsx','js']when not configured.Changes
getPageExtensionsfunction to extract pageExtensions from ESLint settingsparseUrlForPagesandgetUrlFromPagesDirectoriesto accept and use pageExtensions parametergetPageExtensions, pass pageExtensions tocachedGetUrlFromPagesDirectoriesUsage
Users can now configure pageExtensions in their ESLint config:
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
Jah-yee