Skip to content

Commit 2439920

Browse files
authored
migrate chunk-6 skip-list dirs (existing targets.bzl + extra TARGETS rules)
Differential Revision: D109082055 Pull Request resolved: pytorch#21382
1 parent 6cd7ecd commit 2439920

3 files changed

Lines changed: 24 additions & 19 deletions

File tree

devtools/etdump/tests/BUCK

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Any targets that should be shared between fbcode and xplat must be defined in
2+
# targets.bzl.
3+
4+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
5+
load(":targets.bzl", "define_common_targets")
6+
7+
oncall("executorch")
8+
9+
define_common_targets(is_fbcode = is_fbcode())

devtools/etdump/tests/TARGETS

Lines changed: 0 additions & 18 deletions
This file was deleted.

devtools/etdump/tests/targets.bzl

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
2+
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
23

3-
def define_common_targets():
4+
def define_common_targets(is_fbcode = False):
45
"""Defines targets that should be shared between fbcode and xplat.
56
67
The directory containing this targets.bzl file should also contain both
@@ -33,3 +34,16 @@ def define_common_targets():
3334
"//executorch/runtime/platform:platform",
3435
],
3536
)
37+
38+
if is_fbcode:
39+
python_unittest(
40+
name = "serialize_test",
41+
srcs = [
42+
"serialize_test.py",
43+
],
44+
deps = [
45+
"//executorch/devtools/etdump:schema_flatcc",
46+
"//executorch/devtools/etdump:serialize",
47+
"//executorch/exir/_serialize:lib",
48+
],
49+
)

0 commit comments

Comments
 (0)