Skip to content

Commit 440509f

Browse files
committed
fix: address remaining CodeRabbit review feedback on PR #35
- chief-of-staff: declare `mcp__slack__conversations_add_message` in frontmatter; it is referenced in the body at line 102 (send action) and would otherwise be unavailable at runtime - .coderabbit.yaml: clarify that skill "When to Use"/"Ideal For" sections live in the document body (not frontmatter); tighten shell-script guidance to `set -euo pipefail` Not changed (disputed): - MCP tool naming convention remains `mcp__<server>__<tool>` (double underscore) — matches existing usage across chief-of-staff, docs-lookup, and gan-evaluator; single-underscore variant would break all current agents - `replace` and `save_memory` kept in the built-in allow-list — this PR itself proves `replace` is valid (it is the fix for #34); the CodeRabbit web-search result claiming they are deprecated is inconsistent with the Gemini CLI version this repo targets
1 parent 674dc6f commit 440509f

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

.coderabbit.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,19 @@ reviews:
5454
is consistent and shell snippets are safely quoted.
5555
- path: "skills/**/*.md"
5656
instructions: |
57-
Skill definitions. Check that frontmatter includes `name` and `description`,
58-
and that "When to Use" / "Ideal For" sections are present and specific.
57+
Skill definitions. Frontmatter must include `name` and `description`.
58+
The document body (not the frontmatter) should contain a "When to Use"
59+
or "Ideal For" section with specific, actionable trigger conditions.
5960
- path: "hooks/**"
6061
instructions: |
6162
Hook scripts and hooks.json. Hooks run automatically on tool events —
6263
any failure impacts all sessions. Verify error handling, quiet logging,
6364
and that exit codes are intentional.
6465
- path: "scripts/**"
6566
instructions: |
66-
Shell scripts must use `set -e`, quote all variables, and avoid
67-
interpolating shell variables into `node -e` strings (use `process.env`
68-
instead). JS scripts target Node.js 20+.
67+
Shell scripts must use `set -euo pipefail`, quote all variables, and
68+
avoid interpolating shell variables into `node -e` strings (use
69+
`process.env` instead). JS scripts target Node.js 20+.
6970
- path: "rules/**/*.md"
7071
instructions: |
7172
Coding rules shipped to end users' ~/.gemini/rules/. Cross-references

agents/chief-of-staff.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: chief-of-staff
33
description: Personal communication chief of staff that triages email, Slack, LINE, and Messenger. Classifies messages into 4 tiers (skip/info_only/meeting_info/action_required), generates draft replies, and enforces post-send follow-through via hooks. Use when managing multi-channel communication workflows.
4-
tools: ["read_file", "search_file_content", "list_directory", "run_shell_command", "replace", "write_file", "mcp__slack__conversations_search_messages", "mcp__slack__channels_list", "mcp__slack__conversations_history"]
4+
tools: ["read_file", "search_file_content", "list_directory", "run_shell_command", "replace", "write_file", "mcp__slack__conversations_search_messages", "mcp__slack__channels_list", "mcp__slack__conversations_history", "mcp__slack__conversations_add_message"]
55
---
66

77
You are a personal chief of staff that manages all communication channels — email, Slack, LINE, Messenger, and calendar — through a unified triage pipeline.

0 commit comments

Comments
 (0)