Commit 440509f
committed
fix: address remaining CodeRabbit review feedback on PR #35
- chief-of-staff: declare `mcp__slack__conversations_add_message` in
frontmatter; it is referenced in the body at line 102 (send action)
and would otherwise be unavailable at runtime
- .coderabbit.yaml: clarify that skill "When to Use"/"Ideal For" sections
live in the document body (not frontmatter); tighten shell-script
guidance to `set -euo pipefail`
Not changed (disputed):
- MCP tool naming convention remains `mcp__<server>__<tool>` (double
underscore) — matches existing usage across chief-of-staff, docs-lookup,
and gan-evaluator; single-underscore variant would break all current
agents
- `replace` and `save_memory` kept in the built-in allow-list — this
PR itself proves `replace` is valid (it is the fix for #34); the
CodeRabbit web-search result claiming they are deprecated is
inconsistent with the Gemini CLI version this repo targets1 parent 674dc6f commit 440509f
2 files changed
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
66 | | - | |
67 | | - | |
68 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
0 commit comments