-
Notifications
You must be signed in to change notification settings - Fork 20
fix: correct invalid Gemini CLI tool names in agents and docs #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
01892d0
fix: correct invalid Gemini CLI tool names in agents and docs
Jamkris b6ed0ff
chore: add CodeRabbit config to skip release PRs and pin agent tool n…
Jamkris 674dc6f
fix: address CodeRabbit review feedback on PR #35
Jamkris 440509f
fix: address remaining CodeRabbit review feedback on PR #35
Jamkris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| language: "en-US" | ||
|
|
||
| tone_instructions: | | ||
| Be concise and direct. Focus on bugs and security issues over style. | ||
|
|
||
| early_access: true | ||
| enable_free_tier: true | ||
|
|
||
| reviews: | ||
| profile: "assertive" | ||
|
|
||
| auto_review: | ||
| enabled: true | ||
| auto_incremental_review: true | ||
| drafts: false | ||
| ignore_title_keywords: | ||
| - "bump version" | ||
| - "release" | ||
| - "chore: bump" | ||
|
|
||
| high_level_summary: true | ||
| poem: false | ||
| collapse_walkthrough: false | ||
| sequence_diagrams: false | ||
|
|
||
| request_changes_workflow: true | ||
| suggested_labels: true | ||
| suggested_reviewers: false | ||
| auto_apply_labels: false | ||
|
|
||
| path_filters: | ||
| - "!node_modules/**" | ||
| - "!package-lock.json" | ||
| - "!*.lock" | ||
| - "!.DS_Store" | ||
|
|
||
| path_instructions: | ||
| - path: "agents/**/*.md" | ||
| instructions: | | ||
| Gemini CLI agent definitions. The YAML frontmatter `tools:` array MUST use | ||
| valid Gemini CLI built-in tool names only: read_file, read_many_files, | ||
| write_file, replace, glob, search_file_content, list_directory, | ||
| run_shell_command, save_memory, web_fetch, google_web_search. Reject | ||
| Claude-style names like `search_files`, `replace_in_file`, `Read`, `Edit`. | ||
| Each agent must have `name` and `description` in frontmatter. | ||
| - path: "commands/**/*.toml" | ||
| instructions: | | ||
| Gemini CLI command definitions in TOML format. Verify command metadata | ||
| is consistent and shell snippets are safely quoted. | ||
| - path: "skills/**/*.md" | ||
| instructions: | | ||
| Skill definitions. Check that frontmatter includes `name` and `description`, | ||
| and that "When to Use" / "Ideal For" sections are present and specific. | ||
| - path: "hooks/**" | ||
| instructions: | | ||
| Hook scripts and hooks.json. Hooks run automatically on tool events — | ||
| any failure impacts all sessions. Verify error handling, quiet logging, | ||
| and that exit codes are intentional. | ||
| - path: "scripts/**" | ||
| instructions: | | ||
| Shell scripts must use `set -e`, quote all variables, and avoid | ||
| interpolating shell variables into `node -e` strings (use `process.env` | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| instead). JS scripts target Node.js 20+. | ||
| - path: "rules/**/*.md" | ||
| instructions: | | ||
| Coding rules shipped to end users' ~/.gemini/rules/. Cross-references | ||
| between `common/` and language-specific files must use relative paths | ||
| (`../common/xxx.md`) and those targets must exist. | ||
| - path: "docs/**/*.md" | ||
| instructions: | | ||
| User-facing documentation. Tool-name mapping tables (Claude Code ↔ Gemini | ||
| CLI) must list only valid Gemini CLI tool names — incorrect mappings here | ||
| propagate into agent/skill definitions. | ||
| - path: "**/*.js" | ||
| instructions: | | ||
| Node.js 20+ project. Use `node:` prefix for built-in modules. Avoid | ||
| mutation — prefer spread/immutable patterns. Handle errors explicitly; | ||
| never swallow silently. | ||
|
|
||
| labeling_instructions: | ||
| - label: "security" | ||
| instructions: "Changes to hooks, scripts executing shell commands, or handling of user config/credential paths" | ||
| - label: "breaking" | ||
| instructions: "Changes to command names, agent tool names, hook event contracts, or public file layout under ~/.gemini/" | ||
| - label: "agents" | ||
| instructions: "Changes under agents/" | ||
| - label: "skills" | ||
| instructions: "Changes under skills/" | ||
| - label: "commands" | ||
| instructions: "Changes under commands/" | ||
| - label: "docs" | ||
| instructions: "Changes under docs/ or top-level markdown files only" | ||
|
|
||
| tools: | ||
| shellcheck: | ||
| enabled: true | ||
| gitleaks: | ||
| enabled: true | ||
| markdownlint: | ||
| enabled: true | ||
| eslint: | ||
| enabled: true | ||
|
|
||
| chat: | ||
| auto_reply: true | ||
|
|
||
| knowledge_base: | ||
| learnings: | ||
| scope: "local" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.