Skip to content

Commit 210c86a

Browse files
committed
use multiview reconstruction 8.0.1-snapshot to test OME scale values
1 parent 24def9b commit 210c86a

4 files changed

Lines changed: 5 additions & 13 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
<bigdataviewer-n5.version>1.0.2</bigdataviewer-n5.version>
104104

105105
<spim_data.version>2.3.5</spim_data.version>
106-
<multiview-reconstruction.version>8.0.0</multiview-reconstruction.version>
106+
<multiview-reconstruction.version>8.0.1-SNAPSHOT</multiview-reconstruction.version>
107107
<BigStitcher.version>2.5.0</BigStitcher.version>
108108

109109
<n5-universe.version>2.3.0</n5-universe.version>

src/main/java/net/preibisch/bigstitcher/spark/CreateFusionContainer.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -377,10 +377,8 @@ else if ( storageType == StorageFormat.N5 || storageType == StorageFormat.ZARR )
377377
(level) -> MipmapTransforms.getMipmapTransformDefault( mrInfo[level].absoluteDownsamplingDouble() );
378378

379379
// extract the resolution of the s0 export
380-
// TODO: this is inaccurate, we should actually estimate it from the final transformn that is applied
381-
// TODO: this is a hack (returns 1,1,1) so the export downsampling pyramid is working
382-
final VoxelDimensions vx = new FinalVoxelDimensions( "micrometer", new double[] { 1, 1, 1 } );// dataGlobal.getSequenceDescription().getViewSetupsOrdered().iterator().next().getVoxelSize();
383-
final double[] resolutionS0 = OMEZarrAttibutes.getResolutionS0( vx, anisotropyFactor, Double.NaN );
380+
final VoxelDimensions vx = dataGlobal.getSequenceDescription().getViewSetupsOrdered().iterator().next().getVoxelSize();
381+
final double[] resolutionS0 = OMEZarrAttibutes.getResolutionS0( vx );
384382

385383
System.out.println( "Resolution of level 0: " + Util.printCoordinates( resolutionS0 ) + " " + "micrometer" ); //vx.unit() might not be OME-ZARR compatiblevx.unit() );
386384

@@ -427,7 +425,7 @@ else if ( storageType == StorageFormat.ZARR )
427425
// TODO: this is inaccurate, we should actually estimate it from the final transformn that is applied
428426
// TODO: this is a hack (returns 1,1,1) so the export downsampling pyramid is working
429427
final VoxelDimensions vx = new FinalVoxelDimensions( "micrometer", new double[] { 1, 1, 1 } );// dataGlobal.getSequenceDescription().getViewSetupsOrdered().iterator().next().getVoxelSize();
430-
final double[] resolutionS0 = OMEZarrAttibutes.getResolutionS0( vx, anisotropyFactor, Double.NaN );
428+
final double[] resolutionS0 = OMEZarrAttibutes.getResolutionS0( vx );
431429

432430
System.out.println( "Resolution of level 0: " + Util.printCoordinates( resolutionS0 ) + " " + "m" ); //vx.unit() might not be OME-ZARR compatiblevx.unit() );
433431

src/main/java/net/preibisch/bigstitcher/spark/SparkAffineFusion.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ public enum DataTypeFusion
153153
@Option(names = { "--prefetch" }, description = "prefetch all blocks required for fusion in each Spark job using unlimited threads, useful in cloud environments (default: false)")
154154
protected boolean prefetch = false;
155155

156-
157156
// TODO: add support for loading coefficients during fusion
158157
@CommandLine.Option(names = { "--intensityN5Path" }, description = "N5/ZARR/HDF5 base path for loading coefficients (e.g. s3://myBucket/coefficients.n5)")
159158
private String intensityN5PathURIString = null;
@@ -553,11 +552,7 @@ else if ( dataType == DataType.UINT16 )
553552
return gridBlock;
554553

555554
// load intensity correction coefficients for all overlapping views
556-
557-
558555
final Map< ViewId, Coefficients > coefficients;
559-
560-
561556
if ( intensityN5PathURI != null )
562557
{
563558
coefficients = new HashMap<>();
@@ -611,7 +606,6 @@ else if ( dataType == DataType.UINT16 )
611606
System.out.println( "Fusing block: offset=" + Util.printCoordinates( gridBlock[0] ) + ", dimension=" + Util.printCoordinates( gridBlock[1] ) );
612607

613608
// returns a zero-min interval
614-
//blockSupplier = BlkAffineFusion.init(
615609
blockSupplier = BlkAffineFusion.initWithIntensityCoefficients(
616610
conv,
617611
dataLocal.getSequenceDescription().getImgLoader(),

src/main/java/net/preibisch/bigstitcher/spark/SparkResaveN5.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ public Void call() throws Exception
220220
viewId,
221221
dataTypes.get( viewId.getViewSetupId() ),
222222
dimensions.get( viewId.getViewSetupId() ),
223-
//dataGlobal.getSequenceDescription().getViewDescription( viewId ).getViewSetup().getVoxelSize().dimensionsAsDoubleArray(), // TODO: this is a hack for now
223+
dataGlobal.getSequenceDescription().getViewDescription( viewId ).getViewSetup().getVoxelSize().dimensionsAsDoubleArray(),
224224
compression,
225225
blockSize,
226226
downsamplings);

0 commit comments

Comments
 (0)