fix+feat: v1.8.3.0 — AlwaysOn primary detection, CollationChange, Collation reports

Uwe Janke · claude · Uwe Janke · commit bad96985619b · 2026-06-29T09:23:58.000+02:00
Sync-sqmLoginsToAlwaysOn:
- Fix primary replica detection when running from secondary: replace
  dm_hadr_availability_replica_states (role_desc=NULL on secondary) with
  dm_hadr_availability_group_states.primary_replica (always populated)
- Fix Write-EventLog AccessDenied leaking to console: add -ErrorAction
  SilentlyContinue to EventLog writes (EventId 9002/9003)

Invoke-sqmCollationChange:
- Fix PropertyAssignmentException: remove CreateNoNewWindow=$true
  (redundant when UseShellExecute=$false + RedirectStandard*=$true)

Get-sqmSQLInstanceCheck:
- Add Instance Collation check (always Info)
- Add Database Collation vs Instance check (Warning, -Detailed only)

Compare-sqmServerConfiguration:
- Always emit Collation (Instance) row regardless of match (Category=Collation)

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,33 @@
 # sqmSQLTool — Changelog
 
+## [1.8.3.0] — 2026-06-29
+
+### Bugfixes & Erweiterungen
+
+**`Sync-sqmLoginsToAlwaysOn`**
+- Fix: Primary-Replica-Erkennung schlaegt auf Secondary-Instanzen nicht mehr fehl.
+  `sys.dm_hadr_availability_replica_states.role_desc` liefert NULL/RESOLVING wenn von
+  einer Secondary abgefragt — Umstieg auf `sys.dm_hadr_availability_group_states.primary_replica`,
+  das auf jeder Replica den aktuellen Primary enthaelt.
+- Fix: `Write-EventLog`-Fehler (AccessDenied) leckte auf die Konsole, weil der Setter eine
+  non-terminating Exception wirft, die `catch { }` nicht abfaengt.
+  `-ErrorAction SilentlyContinue` ergaenzt (EventId 9002 / 9003).
+
+**`Invoke-sqmCollationChange`**
+- Fix: `PropertyAssignmentException` bei `ProcessStartInfo.CreateNoNewWindow = $true` entfernt.
+  Die Property kann nicht gesetzt werden wenn `UseShellExecute` noch nicht evaluiert wurde.
+  Redundant: bei `UseShellExecute = $false` + `RedirectStandard* = $true` entsteht ohnehin
+  kein Konsolenfenster.
+
+**`Get-sqmSQLInstanceCheck`**
+- Neu: Check **Instance Collation** (Status `Info`) — meldet `server.Collation` in jedem Lauf.
+- Neu: Check **Database Collation vs. Instance** (nur mit `-Detailed`) — listet alle
+  Benutzerdatenbanken, deren Collation von der Instanz-Collation abweicht, als `Warning`.
+
+**`Compare-sqmServerConfiguration`**
+- Neu: **Collation (Instance)** wird jetzt immer im Report ausgegeben (`Category = "Collation"`),
+  nicht nur bei Abweichung — wichtig fuer Migrationschecks.
+
 ## [1.8.2.0] — 2026-06-26
 
 ### ✨ Temporäre Sysadmin-Rechte: AD-Login-Anlage, Cleanup & AlwaysOn
diff --git a/Public/Compare-sqmServerConfiguration.ps1 b/Public/Compare-sqmServerConfiguration.ps1
@@ -1,4 +1,4 @@
-﻿<#
+<#
 .SYNOPSIS
     Compares important configuration settings between two SQL Server instances.
 
@@ -92,6 +92,7 @@ function Compare-sqmServerConfiguration
 			$targetProps = Get-ServerProps $TargetInstance
 			foreach ($key in $sourceProps.Keys)
 			{
+				if ($key -eq 'Collation') { continue }
 				if ($sourceProps[$key] -ne $targetProps[$key])
 				{
 					$results.Add([PSCustomObject]@{
@@ -102,6 +103,15 @@ function Compare-sqmServerConfiguration
 						})
 				}
 			}
+
+			# Collation always reported (not just on difference)
+			$results.Add([PSCustomObject]@{
+				Setting     = "Collation (Instance)"
+				SourceValue = $sourceProps['Collation']
+				TargetValue = $targetProps['Collation']
+				Category    = "Collation"
+			})
+
 			if ($CompareDatabases)
 			{
 				$sourceDbs = Get-DatabaseSimple $SourceInstance | Where-Object { -not $_.IsSystemObject }
diff --git a/Public/Get-sqmSQLInstanceCheck.ps1 b/Public/Get-sqmSQLInstanceCheck.ps1
@@ -1,4 +1,4 @@
-﻿<#
+<#
 .SYNOPSIS
 Checks a SQL Server instance against best practices.
 
@@ -322,6 +322,29 @@ function Get-sqmSQLInstanceCheck
 				Status	     = if ($isOld) { "Warning" } else { "OK" }
 				Message	     = if ($isOld) { "Die Version $version ist veraltet. Upgrade empfohlen." } else { "OK." }
 			}
+
+			# 10. Instance Collation
+			$instanceCollation = $server.Collation
+			$results += [PSCustomObject]@{
+				Check       = "Instance Collation"
+				CurrentValue = $instanceCollation
+				Recommended  = "Unternehmensstandard sicherstellen (z.B. Latin1_General_CI_AS)"
+				Status      = "Info"
+				Message     = "Instanz-Collation: $instanceCollation"
+			}
+
+			if ($Detailed)
+			{
+				$allDbs = Get-DbaDatabase -SqlInstance $server -ExcludeSystem -ErrorAction SilentlyContinue
+				$collationMismatch = @($allDbs | Where-Object { $_.Collation -ne $instanceCollation } | ForEach-Object { "$($_.Name): $($_.Collation)" })
+				$results += [PSCustomObject]@{
+					Check       = "Database Collation (vs. Instance)"
+					CurrentValue = if ($collationMismatch.Count -gt 0) { "$($collationMismatch.Count) DB(s) abweichend" } else { "Alle gleich" }
+					Recommended  = "Alle Benutzerdatenbanken sollten Instanz-Collation verwenden ($instanceCollation)"
+					Status      = if ($collationMismatch.Count -gt 0) { "Warning" } else { "OK" }
+					Message     = if ($collationMismatch.Count -gt 0) { "Abweichende Collation: $($collationMismatch -join '; ')" } else { "Alle Benutzerdatenbanken nutzen die Instanz-Collation." }
+				}
+			}
 		}
 		catch
 		{
diff --git a/Public/Invoke-sqmCollationChange.ps1 b/Public/Invoke-sqmCollationChange.ps1
@@ -1,4 +1,4 @@
-﻿<#
+<#
 .SYNOPSIS
     Automatically changes the server collation of a SQL Server instance.
 
@@ -325,10 +325,8 @@ function Invoke-sqmCollationChange
 			Write-Host "  Starte sqlservr.exe im Minimal-Modus mit neuer Collation..." -ForegroundColor Gray
 			$startInfo = [System.Diagnostics.ProcessStartInfo]::new()
 			$startInfo.FileName = $sqlBinPath
-			$sFlag = if ($instanceRegName -ne 'MSSQLSERVER') { " -s`"$instanceRegName`"" } else { '' }
-			$startInfo.Arguments = "-m -T4022 -T3659$sFlag -q `"$NewCollation`""
+			$startInfo.Arguments = "-m -T4022 -T3659 -q `"$NewCollation`""
 			$startInfo.UseShellExecute = $false
-			$startInfo.CreateNoNewWindow = $true
 			$startInfo.RedirectStandardOutput = $true
 			$startInfo.RedirectStandardError = $true
 			$sqlProc = [System.Diagnostics.Process]::Start($startInfo)
diff --git a/Public/Sync-sqmLoginsToAlwaysOn.ps1 b/Public/Sync-sqmLoginsToAlwaysOn.ps1
@@ -278,15 +278,17 @@ ORDER BY name ASC
 SELECT
     ar.replica_server_name,
     ar.availability_mode_desc,
-    drs.role_desc
+    ISNULL(
+        CASE WHEN ar.replica_server_name = ags.primary_replica THEN 'PRIMARY' ELSE 'SECONDARY' END,
+        'RESOLVING'
+    ) AS role_desc
 FROM sys.availability_replicas ar
-INNER JOIN sys.dm_hadr_availability_replica_states drs
-    ON ar.replica_id = drs.replica_id
-WHERE ar.group_id IN (
-    SELECT group_id FROM sys.availability_groups
-    WHERE name = N'$AvailabilityGroupName'
-)
-ORDER BY drs.role ASC
+INNER JOIN sys.availability_groups ag
+    ON ar.group_id = ag.group_id
+LEFT JOIN sys.dm_hadr_availability_group_states ags
+    ON ag.group_id = ags.group_id
+WHERE ag.name = N'$AvailabilityGroupName'
+ORDER BY role_desc ASC
 "@
 
 			$replicas = Invoke-DbaQuery -SqlInstance $SqlInstance -SqlCredential $srcCred -Query $query -ErrorAction Stop
@@ -598,7 +600,8 @@ ORDER BY sp.name
 				$evtSrc = 'sqmSQLTool'
 				if (-not [System.Diagnostics.EventLog]::SourceExists($evtSrc)) { New-EventLog -LogName Application -Source $evtSrc -ErrorAction Stop }
 				Write-EventLog -LogName Application -Source $evtSrc -EntryType Error -EventId 9002 `
-					-Message "sqmSQLTool: Login-Sync fehlgeschlagen AG '$AvailabilityGroupName' auf '$SqlInstance' - Failed=$failedCount"
+					-Message "sqmSQLTool: Login-Sync fehlgeschlagen AG '$AvailabilityGroupName' auf '$SqlInstance' - Failed=$failedCount" `
+					-ErrorAction SilentlyContinue
 			}
 			catch { }
 		}
@@ -622,7 +625,8 @@ ORDER BY sp.name
 						$evtSrc = 'sqmSQLTool'
 						if (-not [System.Diagnostics.EventLog]::SourceExists($evtSrc)) { New-EventLog -LogName Application -Source $evtSrc -ErrorAction Stop }
 						Write-EventLog -LogName Application -Source $evtSrc -EntryType Warning -EventId 9003 `
-							-Message "sqmSQLTool: AD-verwaiste Logins auf '$SqlInstance' AG '$AvailabilityGroupName' - Count=$($adOrphans.Count): $orphanNames"
+							-Message "sqmSQLTool: AD-verwaiste Logins auf '$SqlInstance' AG '$AvailabilityGroupName' - Count=$($adOrphans.Count): $orphanNames" `
+							-ErrorAction SilentlyContinue
 					}
 					catch { }
 				}
diff --git a/sqmSQLTool.psd1 b/sqmSQLTool.psd1
@@ -1,4 +1,4 @@
-﻿<#	
+<#	
 	===========================================================================
 	 Created with: 	SAPIEN Technologies, Inc., PowerShell Studio 2021 v5.8.183
 	 Created on:   	21.04.2026 15:37
@@ -17,7 +17,7 @@
 	RootModule			   = 'sqmSQLTool.psm1'
 	
 	# Version number of this module.
-	ModuleVersion		   = '1.8.2.0'
+	ModuleVersion		   = '1.8.3.0'
 	
 	# ID used to uniquely identify this module
 	GUID				   = 'c4b10ba2-aee2-4d8d-ad86-a6e97c346ba6'

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<#`
	`1`	`+<#`
`2`	`2`	`.SYNOPSIS`
`3`	`3`	`Compares important configuration settings between two SQL Server instances.`
`4`	`4`
`@@ -92,6 +92,7 @@ function Compare-sqmServerConfiguration`
`92`	`92`	`$targetProps = Get-ServerProps $TargetInstance`
`93`	`93`	`foreach ($key in $sourceProps.Keys)`
`94`	`94`	`{`
	`95`	`+ if ($key -eq 'Collation') { continue }`
`95`	`96`	`if ($sourceProps[$key] -ne $targetProps[$key])`
`96`	`97`	`{`
`97`	`98`	`$results.Add([PSCustomObject]@{`
`@@ -102,6 +103,15 @@ function Compare-sqmServerConfiguration`
`102`	`103`	`})`
`103`	`104`	`}`
`104`	`105`	`}`
	`106`	`+`
	`107`	`+ # Collation always reported (not just on difference)`
	`108`	`+ $results.Add([PSCustomObject]@{`
	`109`	`+ Setting = "Collation (Instance)"`
	`110`	`+ SourceValue = $sourceProps['Collation']`
	`111`	`+ TargetValue = $targetProps['Collation']`
	`112`	`+ Category = "Collation"`
	`113`	`+ })`
	`114`	`+`
`105`	`115`	`if ($CompareDatabases)`
`106`	`116`	`{`
`107`	`117`	`$sourceDbs = Get-DatabaseSimple $SourceInstance \| Where-Object { -not $_.IsSystemObject }`