🚨 test(commit): add tests for reasoning effort handling and implement helper

Author: Jannchie

tests/unit/test_commit.py

@@ -449,7 +449,7 @@ def test_generate_commit_with_ai_failure(self, mock_console, mock_create_client,
     @patch("tgit.commit.commit_prompt_template")
     @patch("tgit.commit.settings")
     def test_generate_commit_with_ai_reasoning_model(self, mock_settings, mock_template, mock_console, mock_create_client, mock_check):
-        """Test reasoning effort is added for reasoning-capable models."""
+        """Test legacy reasoning models keep the existing effort value."""
         mock_client = Mock()
         mock_create_client.return_value = mock_client
         mock_template.render.return_value = "system prompt"
@@ -468,6 +468,33 @@ def test_generate_commit_with_ai_reasoning_model(self, mock_settings, mock_templ
         _, kwargs = mock_client.responses.parse.call_args
         assert kwargs["reasoning"] == {"effort": "minimal"}
 
+    @patch("tgit.commit._check_openai_availability")
+    @patch("tgit.commit._create_openai_client")
+    @patch("tgit.commit.console")
+    @patch("tgit.commit.commit_prompt_template")
+    @patch("tgit.commit.settings")
+    def test_generate_commit_with_ai_gpt5_reasoning_model_uses_low_effort(
+        self, mock_settings, mock_template, mock_console, mock_create_client, mock_check
+    ):
+        """Test GPT-5 reasoning models use a supported effort value."""
+        mock_client = Mock()
+        mock_create_client.return_value = mock_client
+        mock_template.render.return_value = "system prompt"
+        mock_settings.model = "gpt-5.4-mini"
+
+        mock_response = Mock()
+        mock_commit_data = CommitData(type="fix", scope=None, msg="correct bug", is_breaking=False, secrets=[])
+        mock_response.output_parsed = mock_commit_data
+        mock_client.responses.parse.return_value = mock_response
+
+        result = _generate_commit_with_ai("diff content", None, "main")
+
+        assert result == mock_commit_data
+        mock_check.assert_called_once()
+        mock_create_client.assert_called_once()
+        _, kwargs = mock_client.responses.parse.call_args
+        assert kwargs["reasoning"] == {"effort": "low"}
+
 
 class TestGetAICommand:
     """Test get_ai_command function."""

tests/unit/test_commit_coverage.py

@@ -3,6 +3,7 @@
 import pytest
 from tgit.commit import (
     CommitArgs,
+    _get_reasoning_effort,
     _supports_reasoning,
     get_ai_command,
     get_file_change_sizes,
@@ -18,6 +19,14 @@ def test_supports_reasoning_empty(self):
         assert _supports_reasoning("") is False
         assert _supports_reasoning(None) is False
 
+    def test_get_reasoning_effort_for_gpt5(self):
+        """Test GPT-5 models use a supported reasoning effort."""
+        assert _get_reasoning_effort("gpt-5.4-mini") == "low"
+
+    def test_get_reasoning_effort_for_legacy_reasoning_model(self):
+        """Test legacy reasoning models keep the previous effort."""
+        assert _get_reasoning_effort("o1-mini") == "minimal"
+
     def test_get_file_change_sizes_value_error(self):
         """Test get_file_change_sizes with invalid numstat."""
         repo = Mock()

tgit/commit.py

@@ -93,6 +93,17 @@ def _supports_reasoning(model: str) -> bool:
     return any(hint in model_lower for hint in REASONING_MODEL_HINTS)
 
 
+def _get_reasoning_effort(model: str) -> str:
+    """Return a model-compatible default reasoning effort."""
+    model_lower = model.lower()
+
+    # GPT-5 family models reject "minimal" and require the newer effort values.
+    if "gpt-5" in model_lower:
+        return "low"
+
+    return "minimal"
+
+
 def get_changed_files_from_status(repo: git.Repo) -> set[str]:
     """获取所有变更的文件，包括重命名/移动的文件"""
     diff_name_status = repo.git.diff("--cached", "--name-status", "-M")
@@ -254,7 +265,7 @@ def _generate_commit_with_ai(diff: str, specified_type: str | None, current_bran
             "text_format": CommitData,
         }
         if _supports_reasoning(model_name):
-            request_kwargs["reasoning"] = {"effort": "minimal"}
+            request_kwargs["reasoning"] = {"effort": _get_reasoning_effort(model_name)}
 
         chat_completion = client.responses.parse(
             **request_kwargs,