Skip to content

Commit 27657ad

Browse files
committed
[~] allow ordering list properties via index
1 parent 80ef1d9 commit 27657ad

2 files changed

Lines changed: 1 addition & 6 deletions

File tree

janusgraph-core/src/main/java/org/janusgraph/graphdb/query/graph/GraphCentricQueryBuilder.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
package org.janusgraph.graphdb.query.graph;
1616

1717
import com.google.common.base.Preconditions;
18-
import org.janusgraph.core.Cardinality;
1918
import org.janusgraph.core.JanusGraphEdge;
2019
import org.janusgraph.core.JanusGraphElement;
2120
import org.janusgraph.core.JanusGraphQuery;
@@ -201,8 +200,6 @@ public GraphCentricQueryBuilder orderBy(String keyName, org.apache.tinkerpop.gr
201200
Preconditions.checkArgument(key!=null && order!=null,"Need to specify and key and an order");
202201
Preconditions.checkArgument(Comparable.class.isAssignableFrom(key.dataType()),
203202
"Can only order on keys with comparable data type. [%s] has datatype [%s]", key.name(), key.dataType());
204-
Preconditions.checkArgument(key.cardinality()== Cardinality.SINGLE,
205-
"Ordering is undefined on multi-valued key [%s]", key.name());
206203
Preconditions.checkArgument(!orders.containsKey(key), "orders [%s] already contains key [%s]", orders, key);
207204
orders.add(key, Order.convert(order));
208205
return this;

janusgraph-core/src/main/java/org/janusgraph/graphdb/tinkerpop/optimize/step/HasStepFolder.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import org.apache.tinkerpop.gremlin.process.traversal.util.AndP;
3838
import org.apache.tinkerpop.gremlin.process.traversal.util.ConnectiveP;
3939
import org.apache.tinkerpop.gremlin.process.traversal.util.TraversalHelper;
40-
import org.janusgraph.core.Cardinality;
4140
import org.janusgraph.core.JanusGraphTransaction;
4241
import org.janusgraph.core.PropertyKey;
4342
import org.janusgraph.graphdb.query.JanusGraphPredicateUtils;
@@ -120,8 +119,7 @@ static boolean validJanusGraphOrder(OrderGlobalStep orderGlobalStep, Traversal r
120119
final JanusGraphTransaction tx = JanusGraphTraversalUtil.getTx(rootTraversal.asAdmin());
121120
final PropertyKey pKey = tx.getPropertyKey(key);
122121
if (pKey == null
123-
|| !(Comparable.class.isAssignableFrom(pKey.dataType()))
124-
|| (isVertexOrder && pKey.cardinality() != Cardinality.SINGLE)) {
122+
|| !(Comparable.class.isAssignableFrom(pKey.dataType()))) {
125123
return false;
126124
}
127125
}

0 commit comments

Comments
 (0)