ConfigurationManagementGraph to throw Exception with custom ID setting#4708
Open
li-boxuan wants to merge 2 commits into
Open
ConfigurationManagementGraph to throw Exception with custom ID setting#4708li-boxuan wants to merge 2 commits into
li-boxuan wants to merge 2 commits into
Conversation
1b75655 to
ed009e6
Compare
ed009e6 to
97cdbb4
Compare
Fixes JanusGraph#4535 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
97cdbb4 to
55cade1
Compare
Member
Author
|
lol I totally forgot about this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
janusgraph/janusgraph-core/src/main/java/org/janusgraph/graphdb/management/ConfigurationManagementGraph.java
Lines 122 to 131 in 3b8843f
This PR adds a check in ConfigurationManagementGraph to make it clear that it's by design.
Fixes #4535
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?For code changes:
For documentation related changes: