fix cmake presets naming chaos#2
Conversation
preset names have it own scope. use simple and short names were possible
|
NOTE: tested only with cmake -S . --preset=unixlike-clang
cmake --build --preset=clang-release
cmake --build --preset=clang-release --target install
ctest --preset=clang-release |
| }, | ||
| { | ||
| "name": "config-windows-common", | ||
| "name": "windows-common", |
There was a problem hiding this comment.
for the hidden presets that are used to compose the non-hidden presets (using the "inherits") I would prefer to keep the prefix type to prevent any misuse. Those hidden names are not visible to the end user anyway.
There was a problem hiding this comment.
configure, build, and test preets are independent namespaces!
you can't inherit a build preset from a configure preset AFAIK!
There was a problem hiding this comment.
thats' a good point. I changed them all in the most recent version!
| @@ -0,0 +1,1313 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
There was a problem hiding this comment.
Is this necessary? The "version" at the start of the preset file should be enough to define the correct schema.
There was a problem hiding this comment.
If the use want to change the User preset, this schema file is needed to verfiy the preset.
cmake does not help if the preset is invalid!
There was a problem hiding this comment.
I didn't know that. It should be very helpful for debugging. I am sorry but the time I noticed your PR there were just too many conflicts to resolve before the merge... Do you mind doing another PR with this file directly to the cpp_boilerplate_project? I am sorry again that I missed that.
| "displayName": "Release", | ||
| "description": "Set Strict rules for windows msvc (User Mode) release tests", | ||
| "inherits": "test-common-release", | ||
| "inherits": "common-release", |
There was a problem hiding this comment.
I've done most of the changes you suggested in the most recent commits. If you have anything else in mind that will help future users, please comment in my PR to the upstream cpp_boilerplate_project cpp-best-practices#19 so we can merge it with other open cmakepresets issues we have.
There was a problem hiding this comment.
IMHO: to long to write on concole!
|
I have tested this version, you have to test your version again on each host! |
2 participants
preset names have it own scope.
use simple and short names were possible