Skip to content

Commit 0669bb3

Browse files
committed
Notes update
1 parent 1ab083e commit 0669bb3

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

docs/notes/24 - Provide Filtering Capabilities.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* DONE - Get rid of `SearchForExtensionMethods` and related implementation. Let the compiler tell the user if there is a conflict, which is what this switch is trying to do. There's no point in having the generator do that work.
1717
* DONE - Add tests for attribute
1818
* DONE - Pass data through model and use it during code gen
19-
* Add filtering tests
19+
* DONE - Add filtering tests
2020
* DONE - Unit
2121
* DONE - Auto
2222
* DONE - TargetAuto
@@ -26,5 +26,5 @@
2626
* DONE - Integration
2727
* DONE - Auto
2828
* DONE - TargetAuto
29-
* What happens if you add the attribute more than once with different filtering characteristics?
30-
* What happens if you put a property name in the filter list, and that property by name does not exist on the target type?
29+
* DONE - What happens if you add the attribute more than once with different filtering characteristics? Can't happen with `[AutoDeconstruct]` as that is one per type, if it's done with `[TargetAutoDeconstruct]`, a compiler error will occur as two files will have the same on generation.
30+
* DONE - What happens if you put a property name in the filter list, and that property by name does not exist on the target type? Use a `HashSet<string>` to ensure uniqueness, and then if

0 commit comments

Comments
 (0)