Commit 069efaa
committed
Address code review feedback
1. Add XML documentation for IsBuilding property
- Document that it indicates whether a build is in progress
2. Fix StartBuildAssetsOnly progress initialization
- Add Progress.Start() to initialize _progressId
- Add Progress.Finish() in try/catch blocks
- Add EditorUtility.ClearProgressBar() in finally block
- Matches pattern used in StartBuildAll and StartBuildCodeOnly1 parent 88f4e2e commit 069efaa
1 file changed
Lines changed: 13 additions & 0 deletions
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
76 | 79 | | |
77 | 80 | | |
78 | 81 | | |
| |||
143 | 146 | | |
144 | 147 | | |
145 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
146 | 153 | | |
147 | 154 | | |
148 | 155 | | |
149 | 156 | | |
150 | 157 | | |
151 | 158 | | |
152 | 159 | | |
| 160 | + | |
153 | 161 | | |
154 | 162 | | |
155 | 163 | | |
156 | 164 | | |
157 | 165 | | |
| 166 | + | |
158 | 167 | | |
159 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
160 | 173 | | |
161 | 174 | | |
162 | 175 | | |
| |||
0 commit comments