Commit 0cc8383
fix(test): address PR review comments
- JEngineTestBase: save and restore LogAssert.ignoreFailingMessages state
- JEngineTestBase: add XML documentation for virtual methods
- PanelUITests: remove unused _panel field and cleanup code
- PanelUITests: use discard pattern for unused root assignments
- BootstrapEditorUITests: use discard pattern for unused root assignments
- BuildManager: use LINQ Any() for IsIgnoredError filtering
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>1 parent cdee190 commit 0cc8383
4 files changed
Lines changed: 66 additions & 56 deletions
File tree
- UnityProject/Packages
- com.jasonxudeveloper.jengine.core/Editor/CustomEditor
- com.jasonxudeveloper.jengine.ui/Tests/Editor
- Internal
Lines changed: 2 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
551 | 552 | | |
552 | 553 | | |
553 | 554 | | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
559 | | - | |
560 | | - | |
561 | | - | |
| 555 | + | |
562 | 556 | | |
563 | 557 | | |
564 | 558 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
392 | | - | |
| 392 | + | |
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
| |||
521 | 521 | | |
522 | 522 | | |
523 | 523 | | |
524 | | - | |
525 | | - | |
526 | | - | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
527 | 527 | | |
528 | 528 | | |
529 | 529 | | |
| |||
0 commit comments