Skip to content

Commit 203c2aa

Browse files
fix(ci): always create git tags for OpenUPM detection
OpenUPM requires git tags to detect package updates. Updated workflow: **Core Release:** - Tag: v1.0.6 (Core version) - GitHub Release: ✅ Created - CHANGE.md: ## 1.0.6 (Date) **Util-Only Release:** - Tag: util-v1.0.1 (Util version, prefixed with 'util-') - GitHub Release: ❌ Not created - CHANGE.md: ## 1.0.5 (Date) - Util v1.0.1 This ensures: - OpenUPM always detects updates via git tags - GitHub releases only created for Core (version consistency) - Clear distinction between Core and Util-only releases
1 parent fc585f3 commit 203c2aa

1 file changed

Lines changed: 12 additions & 11 deletions

File tree

.github/workflows/release.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ jobs:
108108
echo "release_tag=v${{ inputs.core_version }}" >> $GITHUB_OUTPUT
109109
echo "create_github_release=true" >> $GITHUB_OUTPUT
110110
else
111-
# If only Util is released, use current Core version (no GitHub release)
112-
echo "release_tag=v$CURRENT_CORE_VERSION" >> $GITHUB_OUTPUT
111+
# If only Util is released, create tag for OpenUPM but no GitHub release
112+
echo "release_tag=util-v${{ inputs.util_version }}" >> $GITHUB_OUTPUT
113113
echo "create_github_release=false" >> $GITHUB_OUTPUT
114114
fi
115115
@@ -302,18 +302,18 @@ jobs:
302302
# Update CHANGE.md
303303
- name: Update CHANGE.md
304304
run: |
305-
VERSION="${{ needs.validate.outputs.release_tag }}"
306-
VERSION="${VERSION#v}" # Remove 'v' prefix
307305
DATE=$(date +"%B %d %Y")
308306
309307
# Read the generated changelog
310308
CHANGELOG=$(cat /tmp/changelog.txt)
311309
312310
# Convert changelog to CHANGE.md format
313-
# For Util-only releases, note that Core version didn't change
311+
# For Core releases, use Core version. For Util-only, use Core version with note
314312
if [ "${{ inputs.release_core }}" == "true" ]; then
313+
VERSION="${{ needs.validate.outputs.core_version }}"
315314
CHANGE_ENTRY="## $VERSION ($DATE)\n\n"
316315
else
316+
VERSION="${{ needs.validate.outputs.core_version }}"
317317
CHANGE_ENTRY="## $VERSION ($DATE) - Util v${{ needs.validate.outputs.util_version }}\n\n"
318318
fi
319319
@@ -375,9 +375,8 @@ jobs:
375375
376376
echo "✅ Committed and pushed changes"
377377
378-
# Create Git tag (only when releasing Core)
378+
# Create Git tag (always - needed for OpenUPM detection)
379379
- name: Create Git tag
380-
if: needs.validate.outputs.create_github_release == 'true'
381380
run: |
382381
git tag ${{ needs.validate.outputs.release_tag }}
383382
git push origin ${{ needs.validate.outputs.release_tag }}
@@ -398,15 +397,17 @@ jobs:
398397
fi
399398
400399
echo "" >> $GITHUB_STEP_SUMMARY
400+
echo "🏷️ **Git Tag**: ${{ needs.validate.outputs.release_tag }}" >> $GITHUB_STEP_SUMMARY
401401
402402
if [ "${{ needs.validate.outputs.create_github_release }}" == "true" ]; then
403-
echo "🏷️ **GitHub Release**: Will be created with tag ${{ needs.validate.outputs.release_tag }}" >> $GITHUB_STEP_SUMMARY
403+
echo "📋 **GitHub Release**: Will be created" >> $GITHUB_STEP_SUMMARY
404404
else
405-
echo "ℹ️ **Note**: No GitHub release created (Util-only update)" >> $GITHUB_STEP_SUMMARY
406-
echo "" >> $GITHUB_STEP_SUMMARY
407-
echo "OpenUPM will automatically detect the Util package update from package.json changes." >> $GITHUB_STEP_SUMMARY
405+
echo "ℹ️ **GitHub Release**: Not created (Util-only update)" >> $GITHUB_STEP_SUMMARY
408406
fi
409407
408+
echo "" >> $GITHUB_STEP_SUMMARY
409+
echo "📦 **OpenUPM**: Will detect update from git tag \`${{ needs.validate.outputs.release_tag }}\`" >> $GITHUB_STEP_SUMMARY
410+
410411
create-release:
411412
name: Create GitHub Release
412413
needs: [validate, prepare-release]

0 commit comments

Comments
 (0)