Skip to content

Commit 216ab0b

Browse files
test: verify auto-approve works with last_push_approval enabled
Updated scorecard annotation to reflect that last_push_approval is now enabled. Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
1 parent 91d9ded commit 216ab0b

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.scorecard.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,13 @@ annotations:
4848
reasons:
4949
- reason: not-applicable # Write permissions required for test reporting and release automation
5050

51-
# Branch protection: Using GitHub Rulesets with auto-approve bot
51+
# Branch protection: Using GitHub Rulesets instead of classic branch protection
5252
# - Rulesets require 1 approver (provided by auto-approve bot)
5353
# - Code owner review is required
54-
# - last_push_approval disabled to allow auto-approve bot to work
55-
# - bypass_actors: [] prevents admin bypass
54+
# - last_push_approval enabled
55+
# - bypass_actors: [] prevents admin bypass (equivalent to "apply to administrators")
56+
# Scorecard may not fully recognize ruleset settings vs classic branch protection
5657
- checks:
5758
- branch-protection
5859
reasons:
59-
- reason: not-applicable # Using Rulesets with auto-approve bot requiring last_push_approval disabled
60+
- reason: not-applicable # Using Rulesets; Scorecard may not recognize all settings

0 commit comments

Comments
 (0)