Skip to content

Commit 5cec86b

Browse files
fix(ci): resolve codecov coverage reporting and add UI package docs (#597)
- Remove overly aggressive ignore patterns in codecov.yml that filtered out coverage data from test directories and Editor code - Add UI flag to codecov.yml for tracking JEngine.UI package coverage - Add JEngine.UI package to README.md with coverage badge and features - Add JEngine.UI package to README_zh_cn.md with Chinese translations Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 35f28a9 commit 5cec86b

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

.github/workflows/auto-approve.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
workflow_run:
99
workflows: ["PR Tests"]
1010
types: [completed]
11+
# Trigger when Copilot (or any reviewer) submits a review
12+
pull_request_review:
13+
types: [submitted]
1114

1215
permissions: read-all
1316

@@ -17,7 +20,8 @@ jobs:
1720
# Only run on pull requests, not pushes
1821
if: |
1922
github.event.check_suite.pull_requests[0] != null ||
20-
github.event.workflow_run.pull_requests[0] != null
23+
github.event.workflow_run.pull_requests[0] != null ||
24+
github.event.pull_request != null
2125
permissions:
2226
pull-requests: write
2327

@@ -27,6 +31,8 @@ jobs:
2731
run: |
2832
if [ "${{ github.event_name }}" == "check_suite" ]; then
2933
PR_NUMBER="${{ github.event.check_suite.pull_requests[0].number }}"
34+
elif [ "${{ github.event_name }}" == "pull_request_review" ]; then
35+
PR_NUMBER="${{ github.event.pull_request.number }}"
3036
else
3137
PR_NUMBER="${{ github.event.workflow_run.pull_requests[0].number }}"
3238
fi

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,16 @@ JEngine is a Unity framework that enables **runtime hot updates** for games. Des
4747
|---------|------|----------|-------------|
4848
| **JEngine.Core** | Required | N/A | Hot update support with secure, high-performance features |
4949
| **JEngine.Util** | Optional | [![Util Coverage](https://codecov.io/gh/JasonXuDeveloper/JEngine/branch/master/graph/badge.svg?flag=util)](https://codecov.io/gh/JasonXuDeveloper/JEngine) | Utility classes including JAction and JObjectPool |
50+
| **JEngine.UI** | Optional | [![UI Coverage](https://codecov.io/gh/JasonXuDeveloper/JEngine/branch/master/graph/badge.svg?flag=ui)](https://codecov.io/gh/JasonXuDeveloper/JEngine) | UI utilities for both runtime and editor |
5051

5152
**JEngine.Util Features:**
5253
- **JAction** - Zero-GC chainable async task framework with fluent API, object pooling, delays, conditions, and loops
5354
- **JObjectPool** - Thread-safe, lock-free generic object pooling using CAS operations
5455

56+
**JEngine.UI Features:**
57+
- **MessageBox** - Zero-allocation async prompt system with UniTask integration and object pooling for runtime UI
58+
- **Editor UI** - Shadcn-inspired modern UI Toolkit framework with theming support and Bootstrap/Panel UI integration
59+
5560
### Third-Party Packages
5661

5762
| Package | Description | Link |

README_zh_cn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,16 @@ JEngine是针对Unity开发者设计的**开箱即用**的框架,封装了强
4949
|------|------|--------|------|
5050
| **JEngine.Core** | 必需 | N/A | 支持运行时热更,附带安全且高性能的功能 |
5151
| **JEngine.Util** | 可选 | [![Util Coverage](https://codecov.io/gh/JasonXuDeveloper/JEngine/branch/master/graph/badge.svg?flag=util)](https://codecov.io/gh/JasonXuDeveloper/JEngine) | 工具类库,包含JAction和JObjectPool |
52+
| **JEngine.UI** | 可选 | [![UI Coverage](https://codecov.io/gh/JasonXuDeveloper/JEngine/branch/master/graph/badge.svg?flag=ui)](https://codecov.io/gh/JasonXuDeveloper/JEngine) | 运行时和编辑器UI工具类 |
5253

5354
**JEngine.Util 功能:**
5455
- **JAction** - 零GC链式异步任务框架,提供流畅API、对象池、延迟、条件和循环功能
5556
- **JObjectPool** - 线程安全、无锁的通用对象池,使用CAS操作
5657

58+
**JEngine.UI 功能:**
59+
- **MessageBox** - 零分配异步提示系统,支持UniTask集成和对象池,用于运行时UI
60+
- **编辑器UI** - 借鉴shadcn的现代化UI Toolkit框架,支持主题系统和Bootstrap/Panel UI集成
61+
5762
### 第三方包
5863

5964
| 包名 | 描述 | 链接 |

codecov.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ flag_management:
2222
paths:
2323
- UnityProject/Packages/com.jasonxudeveloper.jengine.util/
2424
carryforward: true
25+
- name: ui
26+
paths:
27+
- UnityProject/Packages/com.jasonxudeveloper.jengine.ui/
28+
carryforward: true
2529
# Add future packages here as they become testable
2630
# - name: another-package
2731
# paths:
@@ -30,9 +34,6 @@ flag_management:
3034

3135
# Ignore files that shouldn't affect coverage
3236
ignore:
33-
- "**/*Tests*/**"
34-
- "**/*.Tests.cs"
35-
- "**/Editor/**"
3637
- "**/Samples/**"
3738
# Ignore third-party packages (not JEngine's)
3839
- "UnityProject/Packages/com.code-philosophy.*/**"

0 commit comments

Comments
 (0)