fix(core): address PR review feedback for Prompt abstraction

- Make ShowDialogAsync thread-safe with volatile backing field and Interlocked.Exchange
- Improve XML documentation for Prompt class with usage examples
- Change default behavior to log error and return false (safer default)
- Add namespace to PromptInitializer (JEngine)
- Add TextMeshPro dependency to jengine.ui package.json
- Remove JEngine.UI dependency from HotUpdate.Code (use Prompt abstraction instead)
- Update EntryPoint.cs to use Prompt.ShowDialogAsync instead of MessageBox.Show

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>

Author: JasonXuDeveloper

UnityProject/Assets/HotUpdate/Code/EntryPoint.cs

@@ -27,7 +27,6 @@
 using JEngine.Core;
 using JEngine.Core.Encrypt;
 using JEngine.Core.Update;
-using JEngine.UI;
 using Obfuz;
 using UnityEngine;
 using UnityEngine.Scripting;
@@ -64,7 +63,7 @@ async UniTask LoadAddOnPackage()
                     {
                         OnStatusUpdate = static status => Debug.Log($"[AddOn1] Status: {GetStatusText(status)}"),
                         OnVersionUpdate = static version => Debug.Log($"[AddOn1] Version: {version}"),
-                        OnDownloadPrompt = static (count, size) => MessageBox.Show("Notice",
+                        OnDownloadPrompt = static (count, size) => Prompt.ShowDialogAsync("Notice",
                             $"[AddOn1] Need to download {count} files, total size {size / 1024f / 1024f:F2}MB. Continue?",
                             "Yes", "No"),
                         OnDownloadProgress = static data =>

UnityProject/Assets/HotUpdate/Code/HotUpdate.Code.asmdef

@@ -12,8 +12,7 @@
         "GUID:3fe1a3e70da50184f9897101cad7e4f2",
         "GUID:6055be8ebefd69e48b49212b09b47b2f",
         "GUID:ba02d1bbd77cf4a0c8606d3e5cbbbe79",
-        "GUID:5c8e1f4d7a3b9e2c6f0d8a4b7e3c1f9d",
-        "GUID:5655bcbaa4dec434b86ecd07e2c6f24d"
+        "GUID:5c8e1f4d7a3b9e2c6f0d8a4b7e3c1f9d"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],

UnityProject/Assets/Scripts/PromptInitializer.cs

@@ -34,25 +34,28 @@
 //    "com.jasonxudeveloper.jengine.ui": "1.0.0"
 //
 // If you don't need MessageBox dialogs, you can:
-// - Delete this script entirely (Bootstrap will log warnings and continue)
+// - Delete this script entirely (Bootstrap will log errors and continue)
 // - Implement your own custom dialog provider by assigning to Prompt.ShowDialogAsync
 // ============================================================================
 
 using JEngine.Core;
 using JEngine.UI;
 using UnityEngine;
 
-/// <summary>
-/// Initializes the Prompt system to use MessageBox for dialogs.
-/// This runs automatically before any scene loads.
-/// </summary>
-public static class PromptInitializer
+namespace JEngine
 {
-    [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
-    private static void Initialize()
+    /// <summary>
+    /// Initializes the Prompt system to use MessageBox for dialogs.
+    /// This runs automatically before any scene loads.
+    /// </summary>
+    public static class PromptInitializer
     {
-        // Register MessageBox as the dialog provider for JEngine.Core
-        Prompt.ShowDialogAsync = MessageBox.Show;
-        Debug.Log("[JEngine] Prompt system initialized with MessageBox provider.");
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
+        private static void Initialize()
+        {
+            // Register MessageBox as the dialog provider for JEngine.Core
+            Prompt.ShowDialogAsync = MessageBox.Show;
+            Debug.Log("[JEngine] Prompt system initialized with MessageBox provider.");
+        }
     }
 }

UnityProject/Packages/com.jasonxudeveloper.jengine.core/Runtime/Prompt.cs

@@ -24,28 +24,55 @@
 //  THE SOFTWARE.
 
 using System;
+using System.Threading;
 using Cysharp.Threading.Tasks;
 using UnityEngine;
 
 namespace JEngine.Core
 {
     /// <summary>
-    /// User prompt/dialog abstraction. Configure ShowDialogAsync to customize behavior.
+    /// Provides an abstraction layer for displaying user prompts and dialogs.
+    /// This allows the core framework to request user input without depending on specific UI implementations.
     /// </summary>
+    /// <remarks>
+    /// <para>
+    /// By default, dialogs log an error and return false. To enable actual dialogs,
+    /// assign a handler to <see cref="ShowDialogAsync"/> before Bootstrap runs.
+    /// </para>
+    /// <para>
+    /// Example using JEngine.UI.MessageBox:
+    /// <code>
+    /// [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
+    /// static void Init() => Prompt.ShowDialogAsync = MessageBox.Show;
+    /// </code>
+    /// </para>
+    /// </remarks>
     public static class Prompt
     {
+        private static volatile Func<string, string, string, string, UniTask<bool>> _showDialogAsync = DefaultShowDialog;
+
         /// <summary>
-        /// Shows a dialog to the user and returns the result.
-        /// Parameters: title, content, okText (null to hide), noText (null to hide)
-        /// Returns: true if OK clicked, false if No/Cancel clicked
-        /// Default: logs warning and returns true (continues execution).
+        /// Gets or sets the dialog handler function.
         /// </summary>
-        public static Func<string, string, string, string, UniTask<bool>> ShowDialogAsync = DefaultShowDialog;
+        /// <value>
+        /// A function that displays a dialog to the user.
+        /// Parameters: title, content, okText (null to hide OK button), noText (null to hide No button).
+        /// Returns: true if OK clicked, false if No/Cancel clicked.
+        /// </value>
+        /// <remarks>
+        /// This property is thread-safe. Assign before Bootstrap runs using
+        /// <c>[RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]</c>.
+        /// </remarks>
+        public static Func<string, string, string, string, UniTask<bool>> ShowDialogAsync
+        {
+            get => _showDialogAsync;
+            set => Interlocked.Exchange(ref _showDialogAsync, value ?? DefaultShowDialog);
+        }
 
         private static UniTask<bool> DefaultShowDialog(string title, string content, string ok, string no)
         {
-            Debug.LogWarning($"[JEngine] Dialog provider not configured. {title}: {content}");
-            return UniTask.FromResult(true);
+            Debug.LogError($"[JEngine] Dialog provider not configured. Cannot display: {title}: {content}");
+            return UniTask.FromResult(false);
         }
     }
 }

UnityProject/Packages/com.jasonxudeveloper.jengine.ui/package.json

@@ -18,6 +18,7 @@
     "url": "https://github.com/JasonXuDeveloper"
   },
   "dependencies": {
-    "com.cysharp.unitask": "2.5.10"
+    "com.cysharp.unitask": "2.5.10",
+    "com.unity.textmeshpro": "3.0.6"
   }
 }