Skip to content

Commit 9ecdfb8

Browse files
fix(core): reset error baseline after filtering YooAsset catalog errors (#610)
BuildManager was incorrectly detecting false positive errors during step 4/4 (GeneratePolymorphicCodes) because the error count baseline was not reset after step 3/4 filtered out known YooAsset catalog errors. The YooAsset PreprocessBuildCatalog throws "Object reference not set" when CatalogTools.CreateCatalogFile is called with null decryption services during HybridCLR's GenerateAll step. This error is correctly filtered by CheckForErrorsExcluding, but subsequent steps still saw the elevated error count. Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 61f5c59 commit 9ecdfb8

File tree

3 files changed

+7
-41
lines changed

3 files changed

+7
-41
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ UnityProject/Build/*
1717
/UnityProject/HybridCLRData
1818
/UnityProject/UserSettings
1919

20+
# Unity package settings (local preferences)
21+
/UnityProject/ProjectSettings/Packages/com.unity.testtools.codecoverage/Settings.json
22+
2023
# Unity Test Framework temporary scenes
2124
/UnityProject/Assets/InitTestScene*.unity
2225
/UnityProject/Assets/InitTestScene*.unity.meta

UnityProject/Packages/com.jasonxudeveloper.jengine.core/Editor/CustomEditor/BuildManager.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,10 @@ private void ExecuteCurrentStep()
237237
CheckForErrorsExcluding("Step 3/4 failed - HybridCLR generation failed",
238238
"Create package main catalog file failed");
239239

240+
// Reset error baseline after filtering excluded errors
241+
// so subsequent steps don't see the ignored YooAsset catalog errors
242+
_errorCountAtStart = GetUnityErrorCount();
243+
240244
_currentStep = BuildStep.GeneratePolymorphicCodes;
241245
break;
242246

UnityProject/ProjectSettings/Packages/com.unity.testtools.codecoverage/Settings.json

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)