docs(plugin): enhance skills with game patterns and troubleshooting (#604)

* docs(plugin): enhance skills with game patterns and troubleshooting

- Add Properties section and all state overloads to JAction skill
- Add async game patterns (cooldown, DoT, wave spawner, health regen)
- Add troubleshooting sections to JAction, JObjectPool, and editor-ui
- Add zero-GC game patterns to JObjectPool (bullet pool, enemy spawner)
- Add game dev examples to editor-ui (settings panel, build tool, asset browser)
- Create new game-patterns skill with comprehensive zero-GC async patterns
- Register new skill in plugin.json

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>

* fix(plugin): address code review feedback on skill documentation

- Add null-conditional operator for TakeDamage in DoT pattern
- Change ReadOnlySpan to array in async wave spawner (ref structs invalid)
- Add Reset() methods to BulletLifetimeState and TypewriterState
- Add Cleanup/Dispose methods to ComboSystem, RegenState, TooltipTrigger
- Fix TypewriterState to use static lambda with state parameter
- Ensure all JActions are properly disposed in long-running patterns

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>

* fix(plugin): remove inaccurate comment about closure in typewriter pattern

The code was already fixed to use static lambda with state parameter,
so the comment suggesting it uses a closure was incorrect.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>

* docs(plugin): clarify ReadOnlySpan vs array usage in async/sync methods

- Add sync version of wave spawner using ReadOnlySpan<T> with ref readonly
- Clarify that async methods cannot use ReadOnlySpan (ref struct limitation)
- Note ReadOnlyMemory<T> as alternative for async with .Span access

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>

---------

Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: JasonXuDeveloper

.claude-plugin/plugin.json

@@ -23,6 +23,7 @@
     "./.claude-plugin/skills/jaction",
     "./.claude-plugin/skills/jobjectpool",
     "./.claude-plugin/skills/messagebox",
-    "./.claude-plugin/skills/editor-ui"
+    "./.claude-plugin/skills/editor-ui",
+    "./.claude-plugin/skills/game-patterns"
   ]
 }

.claude-plugin/skills/editor-ui/SKILL.md

@@ -363,6 +363,134 @@ enum JustifyContent { Start, Center, End, SpaceBetween }
 enum AlignItems { Start, Center, End, Stretch }
 ```
 
+## Game Development Examples
+
+### Settings Panel
+```csharp
+public class GameSettingsWindow : EditorWindow
+{
+    private JToggle _vsyncToggle;
+    private JDropdown<int> _fpsDropdown;
+    private JProgressBar _volumeSlider;
+
+    [MenuItem("Game/Settings")]
+    public static void ShowWindow() => GetWindow<GameSettingsWindow>("Game Settings");
+
+    public void CreateGUI()
+    {
+        var root = new JStack(GapSize.MD);
+        root.style.paddingTop = Tokens.Spacing.Lg;
+        root.style.paddingRight = Tokens.Spacing.Lg;
+        root.style.paddingBottom = Tokens.Spacing.Lg;
+        root.style.paddingLeft = Tokens.Spacing.Lg;
+
+        // Graphics Section
+        var graphics = new JSection("Graphics")
+            .Add(
+                new JFormField("VSync", _vsyncToggle = new JToggle(true)),
+                new JFormField("Target FPS", _fpsDropdown = new JDropdown<int>(
+                    new() { 30, 60, 120, -1 },
+                    defaultValue: 60,
+                    formatSelectedValue: static fps => fps == -1 ? "Unlimited" : $"{fps} FPS",
+                    formatListItem: static fps => fps == -1 ? "Unlimited" : $"{fps} FPS")));
+
+        // Audio Section
+        var audio = new JSection("Audio")
+            .Add(new JFormField("Master Volume", _volumeSlider = new JProgressBar(0.8f)
+                .WithHeight(20)));
+
+        // Actions
+        var actions = new JButtonGroup(
+            new JButton("Apply", ApplySettings, ButtonVariant.Primary),
+            new JButton("Reset", ResetSettings, ButtonVariant.Secondary));
+
+        root.Add(graphics, audio, actions);
+        rootVisualElement.Add(root);
+    }
+}
+```
+
+### Build Tool Window
+```csharp
+public class BuildToolWindow : EditorWindow
+{
+    private JLogView _logView;
+    private JProgressBar _progress;
+    private JStatusBar _status;
+
+    public void CreateGUI()
+    {
+        var root = new JStack(GapSize.MD);
+
+        // Build Configuration
+        var config = new JSection("Build Configuration")
+            .Add(
+                new JFormField("Platform", JDropdown<BuildTarget>.ForEnum(BuildTarget.StandaloneWindows64)),
+                new JFormField("Development", new JToggle(false)),
+                new JFormField("Output", new JTextField("", "Select output folder...")));
+
+        // Progress Section
+        var progressSection = new JSection("Progress")
+            .Add(
+                _progress = new JProgressBar(0f).WithSuccessOnComplete(),
+                _status = new JStatusBar("Ready", StatusType.Info));
+
+        // Log Output
+        _logView = new JLogView(200).WithMinHeight(200).WithMaxHeight(400);
+
+        // Actions
+        var actions = new JButtonGroup(
+            new JButton("Build", StartBuild, ButtonVariant.Primary),
+            new JButton("Clean", CleanBuild, ButtonVariant.Warning),
+            new JButton("Cancel", CancelBuild, ButtonVariant.Danger));
+
+        root.Add(config, progressSection, _logView, actions);
+        rootVisualElement.Add(root);
+    }
+
+    private void UpdateProgress(float value, string message)
+    {
+        _progress.Progress = value;
+        _status.Text = message;
+        _logView.LogInfo(message);
+    }
+}
+```
+
+### Asset Browser Panel
+```csharp
+public class AssetBrowserPanel : EditorWindow
+{
+    public void CreateGUI()
+    {
+        var root = new JStack(GapSize.MD);
+
+        // Navigation
+        var nav = new JRow()
+            .Add(
+                new JIconButton("\u2190", GoBack, "Back"),
+                new JIconButton("\u2192", GoForward, "Forward"),
+                new JIconButton("\u2191", GoUp, "Parent"),
+                JBreadcrumb.FromPath("Assets", "Prefabs", "Characters"))
+            .WithAlign(AlignItems.Center);
+
+        // Toolbar
+        var toolbar = new JRow()
+            .Add(
+                new JTextField("", "Search assets..."),
+                new JDropdown<string>(new() { "All", "Prefabs", "Materials", "Textures" }),
+                new JToggleButton("Grid", "List", true))
+            .WithJustify(JustifyContent.SpaceBetween);
+
+        // Status
+        var status = new JStatusBar("24 items", StatusType.Info);
+
+        root.Add(nav, toolbar, status);
+        rootVisualElement.Add(root);
+    }
+}
+```
+
 ## Example: Complete Editor Window
 
 ```csharp
@@ -409,3 +537,60 @@ public class MyEditorWindow : EditorWindow
     }
 }
 ```
+
+## Troubleshooting
+
+### Theme Not Updating
+- **Problem:** Colors don't change when switching Unity theme
+- **Solution:** Token colors are evaluated at component creation time. Recreate components or use `schedule.Execute()` to refresh on theme change:
+```csharp
+rootVisualElement.schedule.Execute(() => {
+    // Recreate or update component colors
+    myCard.style.backgroundColor = Tokens.Colors.BgSurface;
+}).Every(1000);
+```
+
+### Binding Not Working
+- **Problem:** SerializedProperty binding doesn't update UI
+- **Solution:** Ensure the property path is correct and call `Bind()` on the root:
+```csharp
+var textField = new JTextField();
+textField.BindProperty(serializedObject.FindProperty("myField"));
+rootVisualElement.Bind(serializedObject);
+```
+
+### Component Not Visible
+- **Problem:** Added component doesn't appear
+- **Check:**
+  - Parent has `flexGrow = 1` if using flex layout
+  - Component has non-zero width/height
+  - Parent visibility is not hidden
+
+### Buttons Not Responding
+- **Problem:** Click events not firing
+- **Solution:** Ensure callback is not null and component is enabled:
+```csharp
+var btn = new JButton("Click", () => Debug.Log("Clicked"));
+btn.SetEnabled(true);  // Ensure enabled
+```
+
+### Layout Issues
+- **Problem:** Components overlap or have wrong size
+- **Solution:** Use JStack for vertical, JRow for horizontal layouts:
+```csharp
+// Wrong: direct Add to root
+rootVisualElement.Add(component1);
+rootVisualElement.Add(component2);  // May overlap
+
+// Correct: use layout container
+var stack = new JStack();
+stack.Add(component1, component2);
+rootVisualElement.Add(stack);
+```
+
+### Performance with Many Components
+- **Problem:** Editor window slow with many items
+- **Solution:** Use virtualization for large lists, limit JLogView maxLines:
+```csharp
+var log = new JLogView(maxLines: 100);  // Limit entries
+```