fix(ci): use app token for releases and consistent CHANGE.md formatting#571
Merged
Merged
Conversation
- Use GitHub App token for creating releases so JEngine Release Bot is shown as the author instead of github-actions - Remove bold formatting from CHANGE.md entries for consistency (all entries now use same format regardless of commit type) Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues with the release workflow:
1. Release created by wrong bot
Before: Releases were created by
github-actions[bot]becauseGITHUB_TOKENwas usedAfter: Releases will be created by
jengine-release-bot[bot]using the app token2. Inconsistent CHANGE.md formatting
Before: Conventional commits were bolded, others were not
After: All entries use consistent formatting (no bold)
Test plan
core_version=1.0.9andutil_version=1.0.3🤖 Generated with Claude Code