feat(ci): add DCO sign-off check for pull requests#558
Merged
Conversation
Add a GitHub Actions workflow that verifies all commits in a PR have a 'Signed-off-by' line for Developer Certificate of Origin compliance. - Checks all non-merge commits in the PR - Provides clear error messages with instructions to fix - Shows which specific commits are missing sign-off To enforce this check, enable branch protection rules on master and require the "Verify DCO Sign-off" check to pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
10a0925 to
7b8b9a1
Compare
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How It Works
The workflow runs on every PR and checks each commit for a
Signed-off-by:line. If any commit is missing the sign-off, the check fails with instructions on how to fix it.Example output when commits are missing sign-off:
Required Follow-up Action
After merging this PR, you should enable branch protection rules to enforce the check:
master)masterTest plan
🤖 Generated with Claude Code