fix(ci): fix release workflow regex parsing error#564
Merged
Conversation
The regex pattern for parsing conventional commits contained special characters (parentheses, brackets) that bash was misinterpreting, causing "syntax error in conditional expression: unexpected token ')'" Fix by storing the pattern in a variable first, which prevents bash from parsing the special characters during script expansion. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The release workflow was failing with:
The regex pattern
^([a-z]+)(\(([^)]+)\))?!?:\ (.+)$contains parentheses and brackets that bash was misinterpreting during script expansion.Solution
Store the regex pattern in a variable first:
This prevents bash from parsing the special characters during expansion.
Test plan
🤖 Generated with Claude Code